Skip to content

at86rf2xx: framebuffer idle_state#10291

Closed
Josar wants to merge 1 commit intoRIOT-OS:masterfrom
Josar:pr/at86rf2xx_framebuffer
Closed

at86rf2xx: framebuffer idle_state#10291
Josar wants to merge 1 commit intoRIOT-OS:masterfrom
Josar:pr/at86rf2xx_framebuffer

Conversation

@Josar
Copy link
Contributor

@Josar Josar commented Oct 29, 2018

The idle_state is save when starting to transmitt. But this is not obvious and not intuitiv to understand.
Setting the idle state when changing the state is more intuitiv and should result in the same behaviour.

#9509 (comment)

@PeterKietzmann PeterKietzmann added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Area: drivers Area: Device drivers labels Nov 5, 2018
@PeterKietzmann PeterKietzmann requested review from jnohlgard and kYc0o and removed request for jnohlgard November 6, 2018 08:09
@jnohlgard
Copy link
Member

Did you experience any issues without this PR?
What happens when recv is called multiple times (without dropping the frame buffer)?
From just looking at the code it seems like PLL_ON would be written to dev->idle_state on the second invocation, causing the transceiver to remain in PLL_ON after the frame has been read out instead of going back to RX_AACK_ON. I did not have time to test this PR yet.

@Josar
Copy link
Contributor Author

Josar commented Nov 13, 2018

@gebart you are right. I think this PR is wrong. I was confused when reviewing #9509 . As it is hard to understand when the idle state is saved. This should be better documented, imho.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: drivers Area: Device drivers Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants