Skip to content

backport: 2018.10 compile fixes#10759

Merged
miri64 merged 3 commits intoRIOT-OS:2018.10-branchfrom
kaspar030:2018.10-compile-fixes
Jan 14, 2019
Merged

backport: 2018.10 compile fixes#10759
miri64 merged 3 commits intoRIOT-OS:2018.10-branchfrom
kaspar030:2018.10-compile-fixes

Conversation

@kaspar030
Copy link
Contributor

@kaspar030 kaspar030 commented Jan 12, 2019

Contribution description

Backport of some compile fixes from master.

Testing procedure

Compilation by CI should be sufficient.

Issues/PRs references

Needed to make #10757 pass CI.

@kaspar030 kaspar030 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: release backport Integration Process: The PR is a release backport of a change previously provided to master labels Jan 12, 2019
@kaspar030 kaspar030 requested a review from miri64 January 12, 2019 16:43
@miri64 miri64 added Area: build system Area: Build system Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) labels Jan 12, 2019
@miri64
Copy link
Member

miri64 commented Jan 12, 2019

Can you please reference the original commits somewhere?

Copy link
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See e.g. commit message in my backport PR:

1431a27

@kaspar030 kaspar030 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jan 12, 2019
cladmi and others added 3 commits January 14, 2019 10:28
Upstream rewrote history in master which changed our reference commit from

    intel/tinycrypt@3ea1a60

to

    intel/tinycrypt@6a22712

Diff can be verified to be empty with:

    intel/tinycrypt@6a22712...3ea1a60

(cherry-picked from a07ac29)
@kaspar030 kaspar030 force-pushed the 2018.10-compile-fixes branch from 4e9989b to d663f4d Compare January 14, 2019 09:31
@kaspar030
Copy link
Contributor Author

Can you please reference the original commits somewhere?

Done. Only after I learned about "git cherry-pick -x" ...

@miri64
Copy link
Member

miri64 commented Jan 14, 2019

Unrelated problem: I think Travis tries to rebase to master. We should fix that.

Copy link
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@miri64 miri64 merged commit 2d16226 into RIOT-OS:2018.10-branch Jan 14, 2019
@kaspar030 kaspar030 deleted the 2018.10-compile-fixes branch January 14, 2019 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: build system Area: Build system CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: release backport Integration Process: The PR is a release backport of a change previously provided to master Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants