boards: Add support for the Arduino-Leonardo by maribu · Pull Request #11227 · RIOT-OS/RIOT

maribu · 2019-03-21T13:45:48Z

Contribution description

Adds support for the ATmega32U4 cpu
Adds support for the Arduino Leonardo

Testing procedure

Try to flash and run some tests and examples, such as examples/hello-world. Keep in mind that most tests and examples require more resources (RAM & flash) than the Arduino Leonardo has.

Issues/PRs references

This PR is basically a rebase of #7306

miri64 · 2019-04-27T10:22:17Z

There are some differences between my branch (see #7306 (comment)) and this PR, so I need to retest. My branch also contains a lot of BOARD_INSUFFICIENT_MEMORY sets, so maybe this helps getting this through Murdock ;-).

maribu · 2019-04-27T18:34:17Z

There are some differences between my branch (see #7306 (comment)) and this PR, so I need to retest.

Sorry for the extra effort. Some refactoring of the AVR based boards has been merged since. Those required adaptations of the code to match current master.

My branch also contains a lot of BOARD_INSUFFICIENT_MEMORY sets, so maybe this helps getting this through Murdock ;-).

Thanks for the hint. I'll check that out. But if I remember correctly those adaptations have been done prior to the merge of the Arduino Nano - which needed to be added to BOARD_INSUFFICIENT_MEMORY for 99% of the apps and tests. I fear that your commit will no longer merge. I'll look into that once this PR is otherwise ready to merge, as a rebase mighy be required to update BOARD_INSUFFICIENT_MEMORY for new tests/apps merged since opening this PR.

miri64 · 2019-05-23T12:31:12Z

Sorry for testing only now, but I was quite busy the past month. examples/hello-world works, tests/periph_timer fails. This was a problem in #7306 as well which was later fixed.

maribu · 2019-05-24T07:59:33Z

@miri64: Thanks for pointing that out. While I tried to deduplicate the timer configs of the ATmega1284P and the ATmega32U4 an error sneaked in (2 instead of 3 channels). I separated the configs now in the fix up, as this seems to be more readable.

I also changed the default frequency in tests/periph_timer for the Arduino Leonardo to use the same as for the other ATmega based Arduinos use. With that, the test now passes.

miri64 · 2019-05-24T09:53:06Z

I tested both examples/hello-world and tests/periph_timer again and now both work. Does it make sense to test I²C?

maribu · 2019-05-24T10:35:57Z

On the one hand the I2C driver is the same on all ATmega boards, on the other hand more testing is always better.

Due to memory constraints it will be a bit difficult to test. E.g. the i2c test overflows the memory. In this branch I rebased this PR against master (to get the i2c_scan shell command) and added the examples/i2c_scan as a minimal RIOT shell with only the commands reboot and i2c_scan provided. This is small enough to fit the Arduino Leonardo and allows very basic testing of the I2C interface.

miri64 · 2019-05-24T10:38:03Z

Tested I²C with tests/drivers_ds1307 (by attaching a ds1307 to the I²C pins first of course). Works 👍.

maribu · 2019-05-24T10:40:12Z

Perfect :-) Thanks :-)

miri64

In summary: I tested on a linux system

examples/hello-world ☑️
tests/periph_timer ☑️
tests/drivers_ds1307 (with a DS1307 attached to the I²C pins) to confirm I²C capability ☑️

Please squash.

miri64 · 2019-05-24T10:48:18Z

Some builds already fail due to memory constraints

maribu · 2019-05-24T10:49:41Z

Yes, all the BOARD_INSUFFICIENT_MEMORY need to be extended. Will take about 30 minutes to do...

miri64 · 2019-05-24T11:34:43Z

Yes, all the BOARD_INSUFFICIENT_MEMORY need to be extended. Will take about 30 minutes to do...

sure. I remember the pain from #7306 ;-)

maribu · 2019-05-24T11:53:25Z

his branch has conflicts that must be resolved

F**k. (These are the BOARD_INSUFFICIENT_MEMORY updates). May I rebase?

miri64 · 2019-05-24T11:54:06Z

Of course!

The Arduino Leonardo requires - like the other ATmega based Arduinos - a different frequency than the default 1000000, as this frequency cannot be achieved on a 16MHz ATmega with any available prescaler.

miri64 · 2019-05-24T14:22:19Z

arduino-leonardo also needs to be blacklisted for 3 application (two because no malloc.h was found, one for because our sys/types.h for avrlibc defines time_t wrong [will fix]).

miri64 · 2019-05-24T14:29:12Z

Ok... apparently making time_t signed leads to problems avrlibc (see #8857). So won't fix.

miri64 · 2019-05-24T14:30:33Z

But for reference, in POSIX it shall be an integer type.

miri64 · 2019-05-24T14:31:33Z

@maribu you may squash. The blacklisting of the tests should be done in a separate commit anyways.

Added arduino-leonardo to BOARD_INSUFFICIENT_MEMORY where needed

Added arduino-leonardo to BOARD_BLACKLIST where needed

miri64 · 2019-05-24T15:53:03Z

You may squash the missing blacklisting for tests/pipe immediately. Let's finally get this in!

Added arduino-leonardo to BOARD_BLACKLIST where needed

Added arduino-leonardo to BOARD_INSUFFICIENT_MEMORY where needed

miri64 · 2019-05-24T16:24:55Z

🎉

maribu · 2019-05-24T16:28:45Z

@tprrt: Thank you very much for implementing the Arduino Leonardo support!

@miri64: Thanks for the review and for noticing my mess up with the timers :-)

maribu · 2019-05-24T16:31:02Z

@miri64:

But for reference, in POSIX it shall be an integer type.

I think that integer type does imply whether it is signed or unsigned. E.g. for short int, long int, long long int it is clear that they are signed, but char is also an integer type, but can either by signed or unsigned. (You can use signed char and unsigned char if you need to know what you get.)

miri64 · 2019-05-24T16:36:47Z

I think that integer type does imply whether it is signed or unsigned. E.g. for short int, long int, long long int it is clear that they are signed, but char is also an integer type, but can either by signed or unsigned. (You can use signed char and unsigned char if you need to know what you get.)

You are right. The value mktime() (and in turn timegm()) shall return is (time_t)-1, so it is actually minmea that needs a fix.

miri64 · 2019-05-24T16:37:22Z

Forgot the reference.

miri64 · 2019-05-24T16:38:30Z

Apparently this is fixed in the current version.

miri64 · 2019-05-28T17:07:38Z

examples/default/Makefile


 # Modules to include:
 USEMODULE += shell
-USEMODULE += shell_commands


Why was this removed? oO

Fixed in #11599

I have no idea how that sneaked in. I did touch about every example and test Makefile to update the BOARD_INSUFFICIENT_MEMORY, so I guess I just hit a wrong key and lost track of the changes :-(

Me as well... Shit happens ;-).

maribu added Type: new feature The issue requests / The PR implemements a new feature for RIOT Area: boards Area: Board ports Area: cpu Area: CPU/MCU ports labels Mar 21, 2019

maribu requested review from ZetaR60, kYc0o and miri64 March 21, 2019 13:45

miri64 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label May 23, 2019

miri64 removed the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label May 23, 2019

miri64 approved these changes May 24, 2019

View reviewed changes

miri64 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label May 24, 2019

maribu force-pushed the leonardo branch from e2d868c to 07093c6 Compare May 24, 2019 10:41

tprrt and others added 3 commits May 24, 2019 15:12

cpu/atmega32u4: add support for ATmega32U4

44803ea

board: add support for arduino-leonardo

b63121c

tests/periph_timer: Set freq for Arudino Leonardo

112b88f

The Arduino Leonardo requires - like the other ATmega based Arduinos - a different frequency than the default 1000000, as this frequency cannot be achieved on a 16MHz ATmega with any available prescaler.

maribu force-pushed the leonardo branch from 43b0d80 to 7c8fe41 Compare May 24, 2019 13:41

maribu added 2 commits May 24, 2019 17:23

examples: Updated BOARD_INSUFFICIENT_MEMORY

f4c0af8

Added arduino-leonardo to BOARD_INSUFFICIENT_MEMORY where needed

examples: Updated BOARD_BLACKLIST

75184ad

Added arduino-leonardo to BOARD_BLACKLIST where needed

maribu force-pushed the leonardo branch from c6aa1f4 to 27e78f5 Compare May 24, 2019 15:36

maribu added 2 commits May 24, 2019 17:56

tests: Updated BOARD_BLACKLIST

5522e9e

Added arduino-leonardo to BOARD_BLACKLIST where needed

tests: Updated BOARD_INSUFFICIENT_MEMORY

855b5bd

Added arduino-leonardo to BOARD_INSUFFICIENT_MEMORY where needed

maribu force-pushed the leonardo branch from 27e78f5 to 855b5bd Compare May 24, 2019 15:57

miri64 merged commit 0f3ccb2 into RIOT-OS:master May 24, 2019

miri64 mentioned this pull request May 24, 2019

minmea: bump version to current master #11579

Merged

maribu deleted the leonardo branch May 24, 2019 17:38

miri64 reviewed May 28, 2019

View reviewed changes

miri64 mentioned this pull request May 28, 2019

examples/default: re-introduce shell_commands #11599

Merged

Conversation

maribu commented Mar 21, 2019

Contribution description

Testing procedure

Issues/PRs references

Uh oh!

miri64 commented Apr 27, 2019

Uh oh!

maribu commented Apr 27, 2019

Uh oh!

miri64 commented May 23, 2019

Uh oh!

maribu commented May 24, 2019

Uh oh!

miri64 commented May 24, 2019

Uh oh!

maribu commented May 24, 2019

Uh oh!

miri64 commented May 24, 2019

Uh oh!

maribu commented May 24, 2019

Uh oh!

miri64 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

miri64 commented May 24, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

maribu commented May 24, 2019

Uh oh!

miri64 commented May 24, 2019

Uh oh!

maribu commented May 24, 2019

Uh oh!

miri64 commented May 24, 2019

Uh oh!

miri64 commented May 24, 2019

Uh oh!

miri64 commented May 24, 2019

Uh oh!

miri64 commented May 24, 2019

Uh oh!

miri64 commented May 24, 2019

Uh oh!

miri64 commented May 24, 2019

Uh oh!

miri64 commented May 24, 2019

Uh oh!

maribu commented May 24, 2019

Uh oh!

maribu commented May 24, 2019

Uh oh!

miri64 commented May 24, 2019

Uh oh!

miri64 commented May 24, 2019

Uh oh!

miri64 commented May 24, 2019

Uh oh!

miri64 May 28, 2019

Choose a reason for hiding this comment

Uh oh!

miri64 May 28, 2019

Choose a reason for hiding this comment

Uh oh!

maribu May 28, 2019

Choose a reason for hiding this comment

Uh oh!

miri64 May 28, 2019

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

miri64 left a comment •

edited

Loading

miri64 commented May 24, 2019 •

edited

Loading