Makefile.features: add a common file for the features parsing#11480
Merged
jcarrano merged 1 commit intoRIOT-OS:masterfrom May 3, 2019
Merged
Makefile.features: add a common file for the features parsing#11480jcarrano merged 1 commit intoRIOT-OS:masterfrom
jcarrano merged 1 commit intoRIOT-OS:masterfrom
Conversation
This will allow sharing it between Makefile.include and makefiles/info-global.inc.mk. Also some common variables definition can also be moved to here. Part of moving CPU/CPU_MODEL definition to Makefile.features to have it available before Makefile.include.
cladmi
added
Area: build system
jcarrano
approved these changes
May 3, 2019
Contributor
jcarrano
left a comment
jcarrano
left a comment
There was a problem hiding this comment.
Tested info-boards-supported still works.
Contributor
Author
|
Thanks for the review |
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This will allow sharing it between Makefile.include and
makefiles/info-global.inc.mk.
Also some common variables definition can also be moved to here.
Part of moving CPU/CPU_MODEL definition to Makefile.features to have it
available before Makefile.include.
Next steps
CPU/CPU_MODELonto this oneFEATURES_MISSING/FEATURES_USED/FEATURES_OPTIONAL_USED/FEATURES_CONFLICTINGto this file instead of duplicating itTesting procedure
Features are still parsed, so any example with required features still list the same output like for example
Issues/PRs references
It is part of