Tracking: move CPU/CPU_MODEL to Makefile.features

[cladmi]

Contribution description

This pull request is a tracking pull request for moving the definition of CPU and CPU_MODEL to the board Makefile.features.

Moving these definitions is required to be parse Makefile.dep before `Makefile.include.

It is part of #9913

This pull request is going to be split

• Makefile.features: prerequisites for moving CPU/CPU_MODEL to boards/Makefile.features Makefile.features: prerequisites for moving CPU/CPU_MODEL to boards/Makefile.features #11478

  • Makefile.features: add a common file for the features parsing Makefile.features: add a common file for the features parsing #11480

• Required cleanups

  • kinetis: move filtering-out periph_hwrng in cpu/kinetis kinetis: move filtering-out periph_hwrng in cpu/kinetis #11479
  • boards/common: use Makefile.features boards/common: use Makefile.features #11675
  • boards: move CPU/CPU_MODEL definition to Makefile.features boards: move CPU/CPU_MODEL definition to Makefile.features #12014
  • boards with side-effect: move CPU/CPU_MODEL definition to Makefile.features boards with side-effect: move CPU/CPU_MODEL definition to Makefile.features #12092
  • stm32f103c8: boards/blxxxpill: move CPU/CPU_MODEL to Makefile.features #12332
    • Depends on boards: Split off 128KiB version of bl*pill #12169
  • slwstk6000b BOARD_MODULE and MODULE_CPU, and CPU_MODEL.
    • boards/slwstk6000b-*: move CPU_MODEL definition to Makefile.features boards/slwstk6000b-*: move CPU_MODEL definition to Makefile.features #12410
    • boards/slwstk6000b-*: split one board for each module boards/slwstk6000b-*: split one board for each module  #12343
      • boards/slwstk6000b: move CPU definiton to Makefile.features boards/slwstk6000b: move CPU definiton to Makefile.features #12334
  • boards: remove duplicate include 'RIOTCPU/cpu/Makefile.features' boards: remove duplicate include 'RIOTCPU/cpu/Makefile.features' #12335
  • dist/buildsystem_sanity_check: add check for CPU/CPU_MODEL migration dist/buildsystem_sanity_check: add check for CPU/CPU_MODEL migration #12337
  • makefiles/arch/cortexm.inc.mk: removing setting CPU_MODEL makefiles/arch/cortexm.inc.mk: removing setting CPU_MODEL #12338
  • ...
  • TODO provide a test for everything
    • make: add targets to debug dependencies variables make: add targets to debug dependencies variables #12004

• Move the CPU_MODEL includes for Makefile.nrf52832.features in nrf52/Makefile.features (related to ble/softdevice: add ble_nordic_softdevice feature #11769)

Questions:

CPU_MODEL

Currently the only place left where CPU_MODEL is not defined in board/.../Makefile.features is makefiles/arch/cortexm.inc.mk.

Would it make sense to define with this value by default globally in RIOT if not defined ? I could define it now in Makefile.features.
It would remove the need to define them for cpu fe310, esp*, lpc1768 (the only one using the value of cortexm.inc.mk.

Another solution is to define it in cpu/cortexm_common/Makefile.features but it would be the only one defined in cpu.

Testing procedure

First compiling everything in the CI should still work. The number of jobs should stay the same.

I will also provide a way to verify that the FEATURES_PROVIDED do not change.

I am currently running https://gist.github.com/cladmi/893e63740f935cbfe4087db19a8c17af

./compare_riot_repositories_variable_value_sorted.sh ~/work/git/worktree/riot_master/ ~/work/git/RIOT FEATURES_PROVIDED
...

Issues with:

tests/riotboot_hdr
/bin/sh: 1: arithmetic expression: expecting primary: " + "
/bin/sh: 1: arithmetic expression: expecting primary: " + "
/bin/sh: 1: arithmetic expression: expecting primary: " + "
/bin/sh: 1: arithmetic expression: expecting primary: " + "

For tests/riotboot_hdr, the output always contains this even on master for some boards.

BOARD=hifive1 make --no-print-directory -C tests/riotboot_hdr/ info-debug-variable-FEATURES_PROVIDED
/bin/sh: 1: arithmetic expression: expecting primary: " + "
/bin/sh: 1: arithmetic expression: expecting primary: " + "
periph_gpio periph_gpio_irq periph_rtc periph_rtt periph_timer periph_uart periph_cpuid periph_pm

Issues/PRs references

Tracking issue #9913 on dependency handling order.

[kb2ma]

Reset milestone to 2019.10. We anticipate that the imminent merge of #12410 allows this PR also to be merged.

[cladmi]

Migration is now finished! Thank you for everybody who helped.

Last commit remaining in this branch is the one forbidding the old behavior.
I will move this one to a different PR that will be deprecating this behavior but would be for after the release.

Currently checking that CPU is defined is enforced in RIOT by the dist/tools/build_system_static_check/check.sh script but not in the build system to keep external boards working.

[cladmi]

The PR enforcing the new behavior is in #12417