boards/single: use FLASHFILE#11710
Merged
MrKevinWeiss merged 5 commits intoRIOT-OS:masterfrom Jun 24, 2019
Merged
Conversation
Update to use FLASHFILE as file to be flashed on the board.
Update to use FLASHFILE as file to be flashed on the board.
Update to use FLASHFILE as file to be flashed on the board.
Update to use FLASHFILE as file to be flashed on the board.
Update to use FLASHFILE as file to be flashed on the board.
49 tasks
MrKevinWeiss
approved these changes
Jun 24, 2019
Contributor
MrKevinWeiss
left a comment
There was a problem hiding this comment.
Tested everything without boards and flashed the mbed_lpc1768 with FLASHFILE.
I did notice in the mbed_lpc1768 flash.sh script that a comment says 61: # make sure hexfile was written looks like hexfile has infected more than just the make system 😄
Anyways, ACK!
Contributor
Author
|
Thank you for the review :)
This comment was also in |
Contributor
Author
|
Fix for the comment #11740 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Update the boards that do not use a
commonboard for their flasher.Update to use FLASHFILE as file to be flashed on the board.
Testing procedure
Testing on all the board, or trust the testing without a board.
Testing without a board
The output of the FFLAGS is the same on master and this PR.
for board in ${BOARDS}; do echo ${board}; BOARD=${board} make --no-print-directory -C examples/hello-world/ FLASHER=true flash-only; donefor board in ${BOARDS}; do echo ${board}; FLASHFILE=dogo BOARD=${board} make --no-print-directory -C examples/hello-world/ FLASHER=true flash-only; doneIssues/PRs references
Part of #8838