Skip to content

boards/single: use FLASHFILE#11710

Merged
MrKevinWeiss merged 5 commits intoRIOT-OS:masterfrom
cladmi:pr/boards/single/flashfile
Jun 24, 2019
Merged

boards/single: use FLASHFILE#11710
MrKevinWeiss merged 5 commits intoRIOT-OS:masterfrom
cladmi:pr/boards/single/flashfile

Conversation

@cladmi
Copy link
Contributor

@cladmi cladmi commented Jun 17, 2019

Contribution description

Update the boards that do not use a common board for their flasher.
Update to use FLASHFILE as file to be flashed on the board.

Testing procedure

Testing on all the board, or trust the testing without a board.

BOARDS=$(git diff --name-status HEAD~5 | cut -f 2 -d/)
echo ${BOARDS}
f4vi1 mbed_lpc1768 opencm904 teensy31 telosb z1

Testing without a board

The output of the FFLAGS is the same on master and this PR.

for board in ${BOARDS}; do echo ${board}; BOARD=${board} make --no-print-directory -C examples/hello-world/ FLASHER=true flash-only; done

for board in ${BOARDS}; do echo ${board}; BOARD=${board} make --no-print-directory -C examples/hello-world/ FLASHER=true flash-only; done
f4vi1
true write /home/harter/work/git/RIOT/examples/hello-world/bin/f4vi1/hello-world.bin 0x8000000
mbed_lpc1768
true /home/harter/work/git/RIOT/examples/hello-world/bin/mbed_lpc1768/hello-world.bin
opencm904
true /dev/ttyACM0 /home/harter/work/git/RIOT/examples/hello-world/bin/opencm904/hello-world.bin
teensy31
true --mcu=mk20dx256 /home/harter/work/git/RIOT/examples/hello-world/bin/teensy31/hello-world.hex
telosb
true --telosb -c /dev/ttyUSB0 -r -e -I -p /home/harter/work/git/RIOT/examples/hello-world/bin/telosb/hello-world.hex
z1
true --z1 -I -c /dev/ttyUSB0 -r -e -p /home/harter/work/git/RIOT/examples/hello-world/bin/z1/hello-world.hex

for board in ${BOARDS}; do echo ${board}; FLASHFILE=dogo BOARD=${board} make --no-print-directory -C examples/hello-world/ FLASHER=true flash-only; done

for board in ${BOARDS}; do echo ${board}; FLASHFILE=dogo BOARD=${board} make --no-print-directory -C examples/hello-world/ FLASHER=true flash-only; done
f4vi1
true write dogo 0x8000000
mbed_lpc1768
true dogo
opencm904
true /dev/ttyACM0 dogo
teensy31
true --mcu=mk20dx256 dogo
telosb
true --telosb -c /dev/ttyUSB0 -r -e -I -p dogo
z1
true --z1 -I -c /dev/ttyUSB0 -r -e -p dogo

Issues/PRs references

Part of #8838

cladmi added 5 commits June 17, 2019 18:26
Update to use FLASHFILE as file to be flashed on the board.
Update to use FLASHFILE as file to be flashed on the board.
Update to use FLASHFILE as file to be flashed on the board.
Update to use FLASHFILE as file to be flashed on the board.
Update to use FLASHFILE as file to be flashed on the board.
@cladmi cladmi added Area: build system Area: Build system Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Area: tools Area: Supplementary tools labels Jun 17, 2019
@cladmi cladmi added this to the Release 2019.07 milestone Jun 17, 2019
@cladmi cladmi requested a review from MrKevinWeiss June 17, 2019 16:38
@MrKevinWeiss MrKevinWeiss added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jun 24, 2019
Copy link
Contributor

@MrKevinWeiss MrKevinWeiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested everything without boards and flashed the mbed_lpc1768 with FLASHFILE.
I did notice in the mbed_lpc1768 flash.sh script that a comment says 61: # make sure hexfile was written looks like hexfile has infected more than just the make system 😄

Anyways, ACK!

@MrKevinWeiss MrKevinWeiss merged commit 5481ef1 into RIOT-OS:master Jun 24, 2019
@cladmi
Copy link
Contributor Author

cladmi commented Jun 25, 2019

Thank you for the review :)

comment says 61: # make sure hexfile was written looks like hexfile has infected more than just the make system

This comment was also in calliope-mini and microbit boards flasher, but it was using a binary file.
I should have updated it in 8b2ff28

@cladmi
Copy link
Contributor Author

cladmi commented Jun 25, 2019

Fix for the comment #11740

@cladmi cladmi deleted the pr/boards/single/flashfile branch June 25, 2019 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: build system Area: Build system Area: tools Area: Supplementary tools CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants