Skip to content

boards/mbed_lpc1768: fix file format documentation in flash#11740

Merged
MrKevinWeiss merged 1 commit intoRIOT-OS:masterfrom
cladmi:pr/mbed_lpc1768/fix_file_format_comment
Jun 25, 2019
Merged

boards/mbed_lpc1768: fix file format documentation in flash#11740
MrKevinWeiss merged 1 commit intoRIOT-OS:masterfrom
cladmi:pr/mbed_lpc1768/fix_file_format_comment

Conversation

@cladmi
Copy link
Contributor

@cladmi cladmi commented Jun 25, 2019

Contribution description

The board is flashing using a binary file and not a 'hex' file.
I did not update the documentation when renaming the variable.

The comment was copied from the other boards using 'fscopy' and a
hexfile.

This was found by #11710 (review)

Testing procedure

The file used for flashing is the binary file.

BOARD=mbed_lpc1768 make --no-print-directory -C examples/hello-world/ info-debug-variable-FFLAGS
/home/harter/work/git/RIOT/examples/hello-world/bin/mbed_lpc1768/hello-world.bin

Issues/PRs references

The board is flashing using a binary file and not a 'hex' file.
I did not update the documentation when renaming the variable.

The comment was copied from the other boards using 'fscopy' and a
hexfile.
@cladmi cladmi added Area: doc Area: Documentation Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Area: boards Area: Board ports labels Jun 25, 2019
@cladmi cladmi added this to the Release 2019.07 milestone Jun 25, 2019
@cladmi cladmi requested a review from MrKevinWeiss June 25, 2019 10:37
Copy link
Contributor

@MrKevinWeiss MrKevinWeiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@MrKevinWeiss MrKevinWeiss merged commit 8478265 into RIOT-OS:master Jun 25, 2019
@cladmi cladmi deleted the pr/mbed_lpc1768/fix_file_format_comment branch June 25, 2019 11:30
@cladmi
Copy link
Contributor Author

cladmi commented Jun 25, 2019

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: boards Area: Board ports Area: doc Area: Documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants