Skip to content

Fix typos#12230

Closed
francois-berder wants to merge 2 commits intoRIOT-OS:masterfrom
francois-berder:fix-typos
Closed

Fix typos#12230
francois-berder wants to merge 2 commits intoRIOT-OS:masterfrom
francois-berder:fix-typos

Conversation

@francois-berder
Copy link
Contributor

Contribution description

I recently came accross codespell, a tool that fixes typos in source code. I simply applied this tool to RIOT with this command: codespell -w ..

I did not include any change that affects:

  • vendor headers in cpu/
  • files in pkg/
  • source code (excluding comments and strings)

Testing procedure

This PR does not change the source code. However, since some strings were changed, it might have an effect on tests looking for specific strings.

Issues/PRs references

None

Signed-off-by: Francois Berder <18538310+francois-berder@users.noreply.github.com>
@benpicco benpicco added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation labels Sep 14, 2019
@aabadie
Copy link
Contributor

aabadie commented Sep 14, 2019

Thanks for pointing us to the codespell tool. I tested locally and it's indeed very useful for tracking typos in contributions (see #12232).

In the current state, it will be difficult to merge this PR: there are a lot of files changes, all in a single commit. To make reviewing (and merging) easier for maintainers, I would recommend to merge #12232 first, so we are sure no typos are missing in the changed files and maybe also split this PR in sub-PRs, maybe one PR per top level directories (cpu, boards, drivers, etc) ?

@benpicco
Copy link
Contributor

benpicco commented Sep 15, 2019

Murdock didn't finish succesfully successfully either, so looks like not everything got replaced.

@kaspar030 kaspar030 mentioned this pull request Oct 24, 2019
@kaspar030
Copy link
Contributor

I have rebased and squashed this, the result is 3a9dade in my repo.

@kaspar030
Copy link
Contributor

kaspar030 commented Oct 24, 2019

#12558 fixes edit most of the remaining typos.

@francois-berder
Copy link
Contributor Author

#12558 fixes edit most of the remaining typos.

ok so I am closing this PR.

@francois-berder francois-berder deleted the fix-typos branch October 24, 2019 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants