cpu/mips32r2: remove nomips16 attribute from _mips_handle_exception [backport 2019.07]#12288
Merged
benpicco merged 1 commit intoRIOT-OS:2019.07-branchfrom Sep 23, 2019
Conversation
A note says "The nomips16 attribute should not really be needed, it works around a toolchain issue in 2016.05-03." In fact, in 2018.09-03, the attribute leads to this error: ```cpu/mips32r2_common/thread_arch.c:191:1: error: ‘_mips_handle_exception’ redeclared with conflicting ‘nomips16’ attributes``` This this commit removes the attribute. (cherry picked from commit b415588)
kaspar030
added
CI: ready for build
Contributor
Author
|
Wow, "backport_pr.py" is awesome! 👍 |
benpicco
approved these changes
Sep 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #11986
Contribution description
A note says "The nomips16 attribute should not really be needed,
it works around a toolchain issue in 2016.05-03."
In fact, in 2018.09-03, the attribute leads to this error:
cpu/mips32r2_common/thread_arch.c:191:1: error: ‘_mips_handle_exception’ redeclared with conflicting ‘nomips16’ attributesThis this commit removes the attribute.
Testing procedure
Successful build and basic test on any mips32r2 board should suffice.
Issues/PRs references
Needed for RIOT-OS/riotdocker#76