boards/blxxxpill: move CPU/CPU_MODEL to Makefile.features#12332
Merged
benpicco merged 1 commit intoRIOT-OS:masterfrom Sep 29, 2019
Merged
boards/blxxxpill: move CPU/CPU_MODEL to Makefile.features#12332benpicco merged 1 commit intoRIOT-OS:masterfrom
benpicco merged 1 commit intoRIOT-OS:masterfrom
Conversation
aabadie
added
Type: cleanup
18 tasks
benpicco
approved these changes
Sep 29, 2019
Contributor
benpicco
left a comment
benpicco
left a comment
There was a problem hiding this comment.
Same as the other ones, Murdock will confirm that the location of those defines right now is just for aesthetic consistency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR moves the definition of CPU/CPU_MODEL from Makefile.include to Makefile.features file for bluepill/blackpill (and derivatives) boards.
CPU definition is even moved to
common/blxxxpill/Makefile.featuresbecause it's the same for all variants.Testing procedure
A green Murdock should be enough
Issues/PRs references
Tick one item in #11477