boards: remove duplicate include 'RIOTCPU/cpu/Makefile.features'#12335
Merged
benpicco merged 1 commit intoRIOT-OS:masterfrom Sep 30, 2019
Merged
Conversation
When 'CPU' is defined, the CPU Makefile.features is included by the build system in the main Makefile.features. No need to do it manually anymore.
This was referenced Sep 30, 2019
benpicco
approved these changes
Sep 30, 2019
Contributor
benpicco
left a comment
There was a problem hiding this comment.
Makefiles are included automatically, no need for manual includes.
Contributor
Author
|
Thank you for the review, I will rebase the PRs that depended on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
When 'CPU' is defined, the CPU Makefile.features is included by the
build system in the main Makefile.features.
No need to do it manually anymore.
Testing procedure
Compare the output of
info-buildfor all affected boards. Some duplicate includes are now removed:The 3 removed lines in included makefiles in MAKEFILE_LIST are the 3 lines that are already parsed before:
Difference in info-build between master and this PR
Issues/PRs references
Part of Tracking: move CPU/CPU_MODEL to Makefile.features #11477