Makefile.features: assert CPU is defined by BOARD/Makefile.features#12417
Merged
fjmolinas merged 1 commit intoRIOT-OS:masterfrom Nov 12, 2019
Merged
Conversation
CPU must now be defined by `$(RIOTBOARD)/$(BOARD)/Makefile.features` or one of its common included Makefile.features file. The cpu `Makefile.dep` file can now automatically be included when it exists.
18 tasks
fjmolinas
added
Area: boards
Contributor
|
Looks good, but tagging as |
22 tasks
fjmolinas
removed
the
State: waiting for other PR
Contributor
|
No longer waiting. |
fjmolinas
added
the
CI: ready for build
Contributor
|
Commenting out in |
fjmolinas
approved these changes
Nov 12, 2019
Contributor
fjmolinas
left a comment
fjmolinas
left a comment
There was a problem hiding this comment.
migration was completed, and now that 2019.10 is in we can go forward. ACK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
CPU must now be defined by
$(RIOTBOARD)/$(BOARD)/Makefile.featuresorone of its common included Makefile.features file.
The cpu
Makefile.depfile can now automatically be included when it exists.This now forbids the previous scheme, but with an error message explaining what to do, and updating would still be compatible with a previous version too.
It was just not the good time to do it before the release.
Testing procedure
All boards in RIOT already define
CPUas checked bydist/tools/build_system_sanity_check/check.shand the error are not raised when parsing the makefiles.If I comment the
CPUline inboards/samr21-xpro/Makefile.featuresthen it raises an error.Issues/PRs references
Finalization of the migration done by #11477
#11477 (comment)
Depends on release 2019.10