pkg/arduino_lis3dh: Arduino library for LIS3DH by gschorcht · Pull Request #12518 · RIOT-OS/RIOT

gschorcht · 2019-10-21T00:00:02Z

Contribution description

This PR was initially provided for testing PR #12180, #12118 and #10592 along with a complex library and a known sensor. Now where these PRs are merged, the PR is for demonstrating and testing the Adafruit Unified Sensor Driver package in PR #17460.

It includes PR #17460 (commits ac18140 and fa7d4d9).

Testing procedure

Compilation should succeed in CI. The driver package can be tested with any board that support arduino feature.

BOARD=esp32-wroom-32 make -C tests/pkg_arduino_lis3dh flash term.

Issues/PRs references

Used for PR #12180, #12118 and #10592
Depends on PR #17460

benpicco · 2020-03-24T21:34:32Z

I was a bit confused at first because we already have a driver for lis3dh, but as an example on how to use Arduino drivers this is good to have.
Instead of including a copy of Adafruit_Sensor.h, can you create a separate pkg for the Adafruit_Sensor library that this pkg then depends on?

That would show how an Arduino driver can be used with minimal extra code.

aabadie · 2020-06-23T14:23:15Z

pkg/arduino_lis3dh/Makefile

+.PHONY: all
+
+all:
+	"$(MAKE)" -C $(PKG_BUILDDIR) -f $(CURDIR)/Makefile.arduino_lis3dh


Suggested change

"$(MAKE)" -C $(PKG_BUILDDIR) -f $(CURDIR)/Makefile.arduino_lis3dh

"$(MAKE)" -C $(PKG_BUILDDIR) -f $(RIOTBASE)/Makefile.base MODULE=arduino_lis3dh

And you can remove the Makefile.arduino_lis3dh

aabadie · 2020-06-23T14:25:17Z

tests/arduino_lis3dh/Makefile

+USEMODULE += arduino_lib
+USEMODULE += cpp11-compat


I think these dependencies could moved to the package dependencies.

aabadie · 2020-06-23T14:27:48Z

tests/arduino_lis3dh/Makefile

+USEMODULE += periph_i2c
+USEMODULE += periph_spi


Maybe conditionally add the right module to the build:

ARDUINO_LIS3DH_MODE ?= i2c ifeq (i2c,$(ARDUINO_LIS3DH_MODE)) FEATURES_REQUIRED += periph_i2c else ifeq (spi,$(ARDUINO_LIS3DH_MODE)) FEATURES_REQUIRED += periph_spi CFLAGS += -DARDUINO_LIS3DH_USE_SPI endif

After trying a lot, it is not possible to define such dependencies without changing the original source completely by patching what is not the intention of package. The reason is that both interfaces are implemented by the driver which are not selected statically but by member values.

tests/arduino_lis3dh/Makefile

aabadie · 2020-06-23T14:30:09Z

Instead of including a copy of Adafruit_Sensor.h, can you create a separate pkg for the Adafruit_Sensor library that this pkg then depends on?

+1

This package could have an empty all target and be declared as a pseudo-module (see gemmlowp as an example)

gschorcht · 2022-01-05T05:44:04Z

Instead of including a copy of Adafruit_Sensor.h, can you create a separate pkg for the Adafruit_Sensor library that this pkg then depends on?

+1

This package could have an empty all target and be declared as a pseudo-module (see gemmlowp as an example)

In difference to the gemmlowp package this package does not only provide header files and can be compiled.

A number of Adafruit sensor drivers use the class Adafruit_Sensor from the Adafruit Unified Sensor Driver. To support such drivers, the Adafruit Unified Sensor Driver is imported as package.

The library can be used for testing Arduino I2C and SPI interfaces.

riot-ci · 2022-12-18T15:37:45Z

Murdock results

✔️ PASSED

1ca6b75 fixup! sys/new_delete: add malloc/free based new/delete implementation

Success	Failures	Total	Runtime
2008	0	2008	03m:40s

Artifacts

Documentation preview

17460: pkg/arduino_adafruit_sensor: add Adafruit Unified Sensor Driver as package r=benpicco a=gschorcht ### Contribution description This PR provides the [Adafruit Unified Sensor Driver](https://github.com/adafruit/Adafruit_Sensor) as package. There are a number of Adafruit sensor drivers which all use a common base class `Adafruit_Sensor` from the [Adafruit Unified Sensor Driver](https://github.com/adafruit/Adafruit_Sensor). To support such drivers, the Adafruit Unified Sensor Driver is provided as package. Adafruit sensor driver for ST LSM9DS0 will be provided as separat PR as package for demonstration and testing. PR #12518 will be rebased for testing to have an Adafruit sensor driver for a sensor for which there is a native driver in RIOT. ### Testing procedure Use a board that provides the `arduino` feature and flash ``` BOARD=... make -C tests/pkg_arduino_adafruit_sensor flash test ``` PR #12518 can be used as a more complex test for using the package. ### Issues/PRs references Prerequisite for PR #12518 Co-authored-by: Gunar Schorcht <gunar@schorcht.net>

This was referenced Oct 21, 2019

sys/arduino: Added Wire (I2C) interface #10592

Merged

sys/arduino: Added SPI interface #12118

Merged

smlng added Area: arduino API Area: Arduino wrapper API Area: pkg Area: External package ports Area: tests Area: tests and testing framework labels Oct 21, 2019

gschorcht mentioned this pull request Oct 22, 2019

cpu/esp32: fix CS handling in spi_transfer_bytes #12538

Merged

gschorcht added the State: demonstrator State: This PR (loosely) demonstrates a concept and is not necessarily meant to be merged. label Oct 27, 2019

benpicco mentioned this pull request Jun 19, 2020

boards/sodaq-sara-aff: Initial support #10435

Merged

aabadie reviewed Jun 23, 2020

View reviewed changes

tests/arduino_lis3dh/Makefile Outdated Show resolved Hide resolved

gschorcht force-pushed the pkg/arduino_lis3dh branch from 5e0b7d7 to c21e104 Compare June 25, 2020 10:18

gschorcht requested review from MichelRottleuthner, fjmolinas, leandrolanzieri and smlng as code owners June 25, 2020 10:18

benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Sep 11, 2020

cgundogan added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Sep 14, 2020

jdavid mentioned this pull request Oct 15, 2020

Arduino drivers spectraphilic/wsn_riot#10

Closed

6 tasks

MrKevinWeiss added this to the Release 2021.07 milestone Jun 21, 2021

MrKevinWeiss removed this from the Release 2021.07 milestone Jul 15, 2021

gschorcht mentioned this pull request Jan 2, 2022

pkg/arduino_adafruit_sensor: add Adafruit Unified Sensor Driver as package #17460

Merged

gschorcht force-pushed the pkg/arduino_lis3dh branch from c21e104 to cbdcf86 Compare January 2, 2022 15:40

gschorcht requested a review from cgundogan as a code owner January 2, 2022 15:40

github-actions bot added Area: tools Area: Supplementary tools and removed Area: arduino API Area: Arduino wrapper API labels Jan 2, 2022

gschorcht force-pushed the pkg/arduino_lis3dh branch 2 times, most recently from 6516b75 to 33e62e1 Compare January 3, 2022 05:10

gschorcht mentioned this pull request Jan 3, 2022

sys/new_delete: add malloc/free based new/delete implementation #17464

Merged

gschorcht force-pushed the pkg/arduino_lis3dh branch from 858886c to bed156b Compare January 3, 2022 17:02

gschorcht removed the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jan 3, 2022

gschorcht force-pushed the pkg/arduino_lis3dh branch from bed156b to 2ec2515 Compare January 3, 2022 17:17

gschorcht requested review from kYc0o and maribu as code owners January 3, 2022 17:17

github-actions bot added Area: cpu Area: CPU/MCU ports Area: sys Area: System Platform: AVR Platform: This PR/issue effects AVR-based platforms labels Jan 3, 2022

gschorcht force-pushed the pkg/arduino_lis3dh branch from 2ec2515 to 780b7bb Compare January 3, 2022 21:48

github-actions bot removed Area: cpu Area: CPU/MCU ports Area: sys Area: System Platform: AVR Platform: This PR/issue effects AVR-based platforms labels Jan 3, 2022

gschorcht force-pushed the pkg/arduino_lis3dh branch from 9657881 to cef86b8 Compare January 5, 2022 05:21

gschorcht added 6 commits December 15, 2022 18:36

pkg/arduino_adafruit_sensor: add Adafruit Unified Sensor Driver

7aab412

A number of Adafruit sensor drivers use the class Adafruit_Sensor from the Adafruit Unified Sensor Driver. To support such drivers, the Adafruit Unified Sensor Driver is imported as package.

tests/pkg_arduino_adafruit_sensor: add test app

6b9690c

pkg/arduino_lis3dh: Arduino library for LIS3DH

a8579be

The library can be used for testing Arduino I2C and SPI interfaces.

fixup! pkg/arduino_lis3dh: Arduino library for LIS3DH

822a248

fixup! pkg/arduino_lis3dh: Arduino library for LIS3DH

2fc9a93

fixup! sys/new_delete: add malloc/free based new/delete implementation

1ca6b75

gschorcht force-pushed the pkg/arduino_lis3dh branch from cef86b8 to 1ca6b75 Compare December 15, 2022 20:08

gschorcht requested a review from MrKevinWeiss as a code owner December 15, 2022 20:08

gschorcht added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Dec 18, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

pkg/arduino_lis3dh: Arduino library for LIS3DH#12518

pkg/arduino_lis3dh: Arduino library for LIS3DH#12518
gschorcht wants to merge 6 commits intoRIOT-OS:masterfrom
gschorcht:pkg/arduino_lis3dh

gschorcht commented Oct 21, 2019 •

edited

Loading

Uh oh!

benpicco commented Mar 24, 2020

Uh oh!

aabadie Jun 23, 2020

Uh oh!

aabadie Jun 23, 2020

Uh oh!

aabadie Jun 23, 2020 •

edited

Loading

Uh oh!

gschorcht Jan 5, 2022 •

edited

Loading

Uh oh!

Uh oh!

aabadie commented Jun 23, 2020

Uh oh!

gschorcht commented Jan 5, 2022

Uh oh!

riot-ci commented Dec 18, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

	"$(MAKE)" -C $(PKG_BUILDDIR) -f $(CURDIR)/Makefile.arduino_lis3dh
	"$(MAKE)" -C $(PKG_BUILDDIR) -f $(RIOTBASE)/Makefile.base MODULE=arduino_lis3dh

		USEMODULE += arduino_lib
		USEMODULE += cpp11-compat

		USEMODULE += periph_i2c
		USEMODULE += periph_spi

Conversation

gschorcht commented Oct 21, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Contribution description

Testing procedure

Issues/PRs references

Uh oh!

benpicco commented Mar 24, 2020

Uh oh!

aabadie Jun 23, 2020

Choose a reason for hiding this comment

Uh oh!

aabadie Jun 23, 2020

Choose a reason for hiding this comment

Uh oh!

aabadie Jun 23, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gschorcht Jan 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

aabadie commented Jun 23, 2020

Uh oh!

gschorcht commented Jan 5, 2022

Uh oh!

riot-ci commented Dec 18, 2022

Murdock results

Artifacts

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

gschorcht commented Oct 21, 2019 •

edited

Loading

aabadie Jun 23, 2020 •

edited

Loading

gschorcht Jan 5, 2022 •

edited

Loading