boards: pic32-clicker: check for periph_uart#12744
boards: pic32-clicker: check for periph_uart#12744basilfx wants to merge 1 commit intoRIOT-OS:masterfrom
Conversation
If there is no dependency on periph_uart, then uart_init is not available. This ensure that this will compile fine if periph_uart is not available.
|
|
||
| /* intialise UART used for debug (printf) */ | ||
| #ifdef DEBUG_VIA_UART | ||
| #if MODULE_PERIPH_UART && defined(DEBUG_VIA_UART) |
There was a problem hiding this comment.
IIUC, the whole stuff should be removed.
Indeed that would be better. For now, UART is broken on pic32-clicker. |
|
@francois-berder @aabadie Would it then be OK to merge this in the mean time? It would otherwise block #10741, and the change itself isn't that big :-) |
|
@basilfx OK for me. I will remove these lines anyway in my PR. |
|
Ok, then let's go! |
|
I disagree with the proposed fix here: quick and dirty. It should take 5 minutes to handle this correctly, at least like it's done for the pic32-wifire. If none of you wants to do it, I can open a PR. "Let's do it right this time" (TM) |
I'd say feel free, but I assumed that @francois-berder is already working on that:
So yes, this is a dirty quick fix so we can move on with #10741, with a proper fix in the queue. |
If you don't mind @francois-berder, I'll spend these 5 minutes now and will avoid us to wait a few weeks. Hope this is fine. |
|
Please consider #12768 instead of this PR. |
Contribution description
If there is no dependency on
periph_uart, thenuart_initis not available. This ensure that this will compile fine ifperiph_uartis not available.Testing procedure
Not sure how to test it, but Murdock would fail without this patch in #10741. I also don't have the hardware to test it on real hardware.
Issues/PRs references
#10741