boards/pic32-clicker: cleanup uart configuration and initialization, cleanup header includes#12768
Merged
fjmolinas merged 2 commits intoRIOT-OS:masterfrom Nov 22, 2019
Conversation
aabadie
added
Type: cleanup
Contributor
|
Thanks @aabadie for this PR. I tested on a PIC32 clicker and it is working fine. |
aabadie
force-pushed
the
pr/boards/pic32-clicker-uart-cleanup
branch
from
6aceae4 to
401abd5
Compare
Contributor
Author
|
Thanks for having a look and testing quickly @francois-berder. I updated the PR with your comment and directly squashed. |
fjmolinas
approved these changes
Nov 22, 2019
Contributor
fjmolinas
left a comment
fjmolinas
left a comment
There was a problem hiding this comment.
Changes are good and @francois-berder tested, ACK!.
Contributor
Author
|
Thanks, that was fast :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR cleans up the UART initialization and configuration similar to what was done in #12256.
This is an alternative to #12744.
This PR is untested. but maybe @francois-berder could give it a try.
Testing procedure
Issues/PRs references
Alternative to #12744 (and thus closes #12744), leftover from #12256