fe310: fix power management configuration#13229
Merged
aabadie merged 1 commit intoRIOT-OS:masterfrom Jan 30, 2020
Merged
Conversation
aabadie
reviewed
Jan 29, 2020
Contributor
aabadie
left a comment
aabadie
left a comment
There was a problem hiding this comment.
I'm not sure if PROVIDES_PM_OFF should be defined for this CPU since the existing implementation of pm_off is empty.
aabadie
added
Area: cpu
nmeum
force-pushed
the
pr/hifive_link_fix
branch
from
ff663e1 to
bd2f5fe
Compare
aabadie
added
the
CI: ready for build
leandrolanzieri
added
Impact: minor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This issue was discovered while implementing link time reordering in #13176. The FE310 provides its own implementation of
pm_offandpm_set_lowest. Without this change the common implementation of these functions would be compiled as well and the linker would (in the default order) disable on of the two. This is why it doesn't result on a build failure without #13176, the change proposed here makes sure that the FE310 version of these functions is used.Testing procedure
Either apply #13176 or just read the code, i.e. verify that a custom implementation of these functions is provided in
cpu/fe310/periph/pm.c.Issues/PRs references
#13176