feather-nrf52840: use CDC ACM as default STDIO#13649
Merged
aabadie merged 1 commit intoRIOT-OS:masterfrom Mar 25, 2020
Merged
Conversation
miri64
added
Type: enhancement
miri64
added
the
CI: ready for build
benpicco
approved these changes
Mar 20, 2020
Contributor
benpicco
left a comment
benpicco
left a comment
There was a problem hiding this comment.
Same pattern as all the other boards that use CDC ACM as default STDIO
Contributor
|
Hmm, looks like |
benpicco
added
CI: ready for build
Contributor
|
Dependency resolution around |
aabadie
reviewed
Mar 23, 2020
fjmolinas
reviewed
Mar 23, 2020
miri64
added
State: waiting for other PR
miri64
force-pushed
the
feather-nrf52840/enh/stdio_cdc_acm
branch
from
84d12dc to
b4edf9a
Compare
miri64
requested review from
MichelRottleuthner,
leandrolanzieri and
smlng
as code owners
benpicco
added
CI: ready for build
miri64
force-pushed
the
feather-nrf52840/enh/stdio_cdc_acm
branch
from
b4edf9a to
66168ef
Compare
Member
Author
|
Rebased to current master to remove the changes from #13703. |
Member
Author
|
Thanks for the review and merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This provides
stdio_cdc_acmas default STDIO for thefeather-nrf52840board.Testing procedure
Everything should still pass the CI,
example/hello-worldstill works onfeather-nrf52840.Issues/PRs references
Follow-up on #12304.
Depends on
#13703(merged).