riotboot: disable stdio_cdc_acm#13674
Merged
kaspar030 merged 1 commit intoRIOT-OS:masterfrom Mar 23, 2020
Merged
Conversation
We don't want USB based stdio in the bootloader.
benpicco
added
Type: bug
kaspar030
approved these changes
Mar 23, 2020
Contributor
kaspar030
left a comment
kaspar030
left a comment
There was a problem hiding this comment.
ACK. As long as this compiles, it should be ok.
We really need proper, automatic size warnings. Adding stdio-cdc-acm in the first place must have increased the bootloader size by quite a bit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
riotbootdisablesauto_init, sostdio_cdc_acmwill not work.But in fact we don't want to pull the whole USB stack in just for debug output of the bootloader, so just disable
stdio_cdc_acmforriotboot.Testing procedure
No change expected since
riotbootdid not work withstdio_cdc_acmto begin with.Issues/PRs references
should fix CI build of #13649