Skip to content

tests/libc_newlib: blacklist esp32 boards temporarily#13814

Merged
benpicco merged 1 commit intoRIOT-OS:masterfrom
gschorcht:cpu/esp32/temp_newlib_fix
Apr 4, 2020
Merged

tests/libc_newlib: blacklist esp32 boards temporarily#13814
benpicco merged 1 commit intoRIOT-OS:masterfrom
gschorcht:cpu/esp32/temp_newlib_fix

Conversation

@gschorcht
Copy link
Contributor

Contribution description

ESP32 boards must be blacklisted for tests/libc_newlib to avoid CI compilation errors until the toolchain is updated on all nodes. This change has to be reverted by merging PR #13812 once all nodes are update.

Testing procedure

Compilation in Murdock has to succeed.

Issues/PRs references

ESP32 boards must be blacklisted for `tests/libc_newlib` to avoid CI compilation errors until the toolchain is updated on all nodes.
@gschorcht gschorcht requested review from biboc and cgundogan and removed request for MichelRottleuthner, aabadie, fjmolinas, leandrolanzieri and smlng April 4, 2020 11:36
@gschorcht gschorcht added Area: cpu Area: CPU/MCU ports Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ESP Platform: This PR/issue effects ESP-based platforms Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) labels Apr 4, 2020
@benpicco
Copy link
Contributor

benpicco commented Apr 4, 2020

Is this still needed?
When @cgundogan said the update takes a while I was expecting a couple of hours, not days - a couple of hours have passed and #13812 is passing

@cgundogan
Copy link
Member

When @cgundogan said the update takes a while I was expecting a couple of hours, not days - a couple of hours have passed and #13812 is passing

not all pods form the haw-icc have yet transitioned to the new docker image. That's unfortunately out of my hands. 10 from the 16 pods still need to update the docker image.

But I am still unsure if breeze and riotbuild updated the image (@kaspar030 and @aabadie can say more here). Nevertheless, most of our nodes are up-to-date. So merging this PR will do more good then harm.

@cgundogan
Copy link
Member

So merging this PR will do more good then harm.

I meant merging the other PR.

@gschorcht
Copy link
Contributor Author

Merging this PR would solve the problem that the compilations for all PRs fail at the moment. If we would then merge PR #13812 in one or two days, everything should be fine.

Copy link
Contributor

@benpicco benpicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well alright then, if building with #13812 is not reliable yet we should probably merge this, so Murdock isn't enforcing a hard feature freeze 😉

@benpicco benpicco merged commit e626c52 into RIOT-OS:master Apr 4, 2020
@leandrolanzieri leandrolanzieri added this to the Release 2020.04 milestone Apr 8, 2020
@leandrolanzieri leandrolanzieri added the Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer label Apr 8, 2020
@gschorcht gschorcht deleted the cpu/esp32/temp_newlib_fix branch June 25, 2020 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: cpu Area: CPU/MCU ports Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Platform: ESP Platform: This PR/issue effects ESP-based platforms Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants