[backport 2020.04] makefiles/info-global: Remove dependency resolution cache#14136
Merged
kaspar030 merged 1 commit intoRIOT-OS:2020.04-branchfrom May 25, 2020
Merged
Conversation
This removes a preliminar dependency resolution that is performed without including features, to skip a full dependency resolution when boards can be proven to be unsupported on an earlier stage. This was introducing issues on some boards since the blacklisting of some features depends on board information which is not available at the time of performing this resolution.
leandrolanzieri
added
Type: bug
maribu
approved these changes
May 25, 2020
Member
maribu
left a comment
maribu
left a comment
There was a problem hiding this comment.
ACK. Tested the backport with same result as the original PR.
leandrolanzieri
changed the title
leandrolanzieri
added
CI: ready for build
Contributor
Author
|
All green! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #14132
Contribution description
This removes a preliminar dependency resolution that is performed without including features, to skip a full dependency resolution when boards can be proven to be unsupported on an earlier stage.
This was introducing issues on some boards since the blacklisting of some features depends on board information which is not available at the time of performing this resolution.
Some time measurements
Running
make info-boards-supported50 times on my computer results in:hello_world873.0 ms ± 20.5 ms851.7 ms ± 26.3 mstests/driver_ws281x(proposed here)266.4 ms ± 11.6 ms263.0 ms ± 18.6 msTesting procedure
make info-boards-supportedshould work properly now (it was pointed out in the mailing list that the sodaq boards are not showing up in the list in current master, for instance)Issues/PRs references
Spotted by @fjmolinas here