makefiles/info-global: Remove dependency resolution cache#14132
Conversation
This removes a preliminar dependency resolution that is performed without including features, to skip a full dependency resolution when boards can be proven to be unsupported on an earlier stage. This was introducing issues on some boards since the blacklisting of some features depends on board information which is not available at the time of performing this resolution.
|
Is it correct, that it is faster without caching? Or is this columns mixed up? In any case, having this working is a higher priority than having it fast. So even if it would slow things down, we obviously have to accept this. |
No, the columns are Ok. When running the benchmark, without the cache took less time. |
|
OK, with this the following additional boards are listed in
I compiled it for each of these, it worked for all. |
|
Thanks for the quick review. |
Then it is extra good to have this in :-) (I'm sure it was noticeably faster with the cache on my machine at the time I added this. I wonder why it turns out slowing down things now.) |
|
@keestux the issue you mentioned on the mailing list should be fixed now with this PR. |
|
does this need a backport? @leandrolanzieri |
Hmm yes, you're right |
|
Backport provided in #14136 |
Contribution description
This removes a preliminar dependency resolution that is performed without including features, to skip a full dependency resolution when boards can be proven to be unsupported on an earlier stage.
This was introducing issues on some boards since the blacklisting of some features depends on board information which is not available at the time of performing this resolution.
Some time measurements
Running
make info-boards-supported50 times on my computer results in:hello_world873.0 ms ± 20.5 ms851.7 ms ± 26.3 mstests/driver_ws281x(proposed here)266.4 ms ± 11.6 ms263.0 ms ± 18.6 msTesting procedure
make info-boards-supportedshould work properly now (it was pointed out in the mailing list that the sodaq boards are not showing up in the list in current master, for instance)Issues/PRs references
Spotted by @fjmolinas here