congure_quic: initial import of QUIC congestion control by miri64 · Pull Request #15952 · RIOT-OS/RIOT

miri64 · 2021-02-08T21:09:45Z

Contribution description

This provides an implementation for CongURE of the congestion control mechanism of the QUIC protocol as specified in draft-ietf-quic-recovery (version 34 at the opening of this PR). It has the advantage of having congestion control via loss and ECN already build in and also provides means for packet pacing, so perfect for SFR!

Testing procedure

Tests are provided for which riotctrl (at least v0.2.2) is required for them to run. If installed,

make -j -C tests/congure_quic flash test

should succeed.

Issues/PRs references

Requires ~~#15951~~ (merged), ~~#16111, and #16119.~~ (merged) When merged, I will adapt the test framework to use the turo framework introduced in #15950, which was the original idea to begin with (which is why it is already printing JSON strings).

miri64 · 2021-02-09T23:37:30Z

Maybe @larseggert also wants to take a look.

miri64 · 2021-02-26T12:13:34Z

Rebased to current master, needs some adaptions to the changes done in #15951, so I am marking this WIP temporarily.

miri64 · 2021-02-26T15:33:19Z

Adapted tests for behavior changes of congure_test in #15951.

miri64 · 2021-02-26T15:48:42Z

And added the new Kconfig stuff (which does not work properly yet, since dependency resolution of ztimer is a bit messy... @leandrolanzieri said he will have a look).

miri64 · 2021-03-01T13:48:56Z

The test framework needed some rework (see #16111) to handle longer parameters, so I will base this PR now on that.

miri64 · 2021-03-02T09:54:32Z

Rebased to current master and dependencies and added #16119 as new dependency.

benpicco

If memory serves me right the only thing missing here were the failing tests - but that seems to be resolved. So ACK.

test is still failing

benpicco · 2022-04-09T10:49:20Z

Arg the new test is still failing

benpicco · 2022-10-12T19:19:14Z

We should be able to merge this if we can get it past CI

miri64 · 2022-10-13T08:03:42Z

Arg the new test is still failing

Mh, but the failures look like actual test failures, not just failure of the test infrastructure. I will investigate after rebase.

miri64 · 2022-10-13T08:08:29Z

But first: Rebase

riot-ci · 2022-10-13T08:15:09Z

Murdock results

✔️ PASSED

1bf241e tests: Initial import of congure_quic tests

Success	Failures	Total	Runtime
1989	0	1989	06m:47s

Artifacts

Documentation preview

This only reflects a subset of all builds from https://ci-prod.riot-os.org. Please refer to https://ci.riot-os.org for a complete build for now.

miri64 · 2022-10-13T08:55:28Z

Fixed.

miri64 · 2022-10-13T08:59:08Z

(there was a bugfix introduced in 1a1792a, however, the old code was not removed; with my fix I took the same bug fix I used for congure_reno)

miri64 · 2022-10-13T09:16:53Z

@leandrolanzieri @MrKevinWeiss there seems to be a Kconfig issue which I don't really understand in Murdock (ci-prod)... locally I can not reproduce this, neither with

TEST_KCONFIG=1 make -C tests/congure_test/ -j

nor

TEST_KCONFIG=0 make -C tests/congure_test/ -j

tests/congure_quic/app.config.test

miri64 · 2022-10-14T09:05:15Z

I'm fine with this one going in only after feature freeze and clearing up the Murdock queue for now.

benpicco

Looking good, Makefile.ci needs two more entries.

sys/congure/quic/congure_quic.c

miri64 added Type: new feature The issue requests / The PR implemements a new feature for RIOT State: waiting for other PR State: The PR requires another PR to be merged first Area: sys Area: System labels Feb 8, 2021

miri64 requested review from MrKevinWeiss, benpicco and maribu February 8, 2021 21:09

miri64 requested review from MichelRottleuthner, aabadie, cgundogan, fjmolinas, jia200x, leandrolanzieri and smlng as code owners February 8, 2021 21:09

miri64 force-pushed the congure/feat/congure_quic branch 2 times, most recently from 7a11318 to 3b5f6ca Compare February 11, 2021 20:08

miri64 force-pushed the congure/feat/congure_quic branch from 3b5f6ca to 485b887 Compare February 26, 2021 12:10

miri64 added State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet and removed State: waiting for other PR State: The PR requires another PR to be merged first labels Feb 26, 2021

miri64 mentioned this pull request Feb 26, 2021

congure_reno: initial import of TCP Reno congestion control #15953

Merged

miri64 mentioned this pull request Mar 1, 2021

congure_test: make shell commands shorter #16111

Merged

miri64 added the State: waiting for other PR State: The PR requires another PR to be merged first label Mar 1, 2021

miri64 force-pushed the congure/feat/congure_quic branch from 95e5479 to c6e9a42 Compare March 2, 2021 09:54

miri64 mentioned this pull request Mar 5, 2021

gnrc_sixlowpan_frag_sfr_congure: add congure_quic support #16159

Merged

miri64 force-pushed the congure/feat/congure_quic branch from ea01143 to 8b9d97f Compare March 9, 2021 11:37

benpicco previously approved these changes Apr 9, 2022

View reviewed changes

benpicco removed this from the Release 2022.04 milestone Oct 11, 2022

miri64 mentioned this pull request Oct 12, 2022

gnrc_sixlowpan_frag_sfr: provide CongURE support #16156

Merged

miri64 force-pushed the congure/feat/congure_quic branch from 7a9831f to 1c36643 Compare October 13, 2022 08:08

miri64 force-pushed the congure/feat/congure_quic branch from 1c36643 to 594a998 Compare October 13, 2022 08:55

miri64 force-pushed the congure/feat/congure_quic branch from 594a998 to 13ab6f8 Compare October 13, 2022 09:06

MrKevinWeiss reviewed Oct 13, 2022

View reviewed changes

tests/congure_quic/app.config.test Outdated Show resolved Hide resolved

miri64 force-pushed the congure/feat/congure_quic branch from 13ab6f8 to 769424a Compare October 13, 2022 09:25

maribu added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Oct 13, 2022

benpicco reviewed Oct 16, 2022

View reviewed changes

sys/congure/quic/congure_quic.c Outdated Show resolved Hide resolved

sys/congure/quic/congure_quic.c Outdated Show resolved Hide resolved

miri64 added 2 commits October 17, 2022 10:27

congure_quic: initial import of QUIC congestion control

fc57bfb

tests: Initial import of congure_quic tests

1bf241e

benpicco approved these changes Oct 17, 2022

View reviewed changes

Conversation

miri64 commented Feb 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Contribution description

Testing procedure

Issues/PRs references

Uh oh!

miri64 commented Feb 9, 2021

Uh oh!

miri64 commented Feb 26, 2021

Uh oh!

miri64 commented Feb 26, 2021

Uh oh!

miri64 commented Feb 26, 2021

Uh oh!

miri64 commented Mar 1, 2021

Uh oh!

miri64 commented Mar 2, 2021

Uh oh!

benpicco left a comment

Choose a reason for hiding this comment

Uh oh!

benpicco commented Apr 9, 2022

Uh oh!

benpicco commented Oct 12, 2022

Uh oh!

miri64 commented Oct 13, 2022

Uh oh!

miri64 commented Oct 13, 2022

Uh oh!

riot-ci commented Oct 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Murdock results

Artifacts

Uh oh!

miri64 commented Oct 13, 2022

Uh oh!

miri64 commented Oct 13, 2022

Uh oh!

miri64 commented Oct 13, 2022

Uh oh!

Uh oh!

miri64 commented Oct 14, 2022

Uh oh!

benpicco left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

miri64 commented Feb 8, 2021 •

edited

Loading

riot-ci commented Oct 13, 2022 •

edited

Loading