makefiles/libc/picolibc.mk: only fail when building#16114
Merged
miri64 merged 1 commit intoRIOT-OS:masterfrom Mar 1, 2021
Merged
makefiles/libc/picolibc.mk: only fail when building#16114miri64 merged 1 commit intoRIOT-OS:masterfrom
miri64 merged 1 commit intoRIOT-OS:masterfrom
Conversation
benpicco
approved these changes
Mar 1, 2021
Member
|
Started another action on current master. This should run through. |
nmeum
added a commit
to nmeum/RIOT
that referenced
this pull request
Aug 5, 2021
This is a regression which was introduced in RIOT-OS#16114, without resetting the color the red color will be used for all following text written to the terminal and will also cause the shell prompt etc. pp. to be colored in red which is undesirable. This commit fixes this regression by using the ANSI escape sequences to reset the color after the error message has been written.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
With #16008 an error is outputted whenever a build is attempted with missing
picolibc. Issue is this check runs always and does when querying build_system variables,eg:This is not desirable since it interferes with a lot of scripts which will exit early, e.g.:
compile_and_test_for_boardas seen here https://github.com/RIOT-OS/RIOT/actions/runs/608883211.This PR refactor the error a bit to run only when building and so is added to
BUILDDEPSTesting procedure
compile_and_test_for_boardsonly the indivusal build fails:Issues/PRs references
Related to #16008