gnrc_sixlowpan_frag_sfr_congure: add congure_abe support#16171
Merged
bors[bot] merged 2 commits intoRIOT-OS:masterfrom Mar 1, 2023
Merged
Conversation
miri64
added
Area: network
miri64
requested review from
MichelRottleuthner,
PeterKietzmann,
aabadie,
cgundogan,
fjmolinas,
haukepetersen,
jia200x,
leandrolanzieri and
smlng
as code owners
miri64
changed the title
miri64
force-pushed
the
gnrc_sixlowpan_frag_sfr_congure_abe/feat/initial
branch
from
22fd6f4 to
75bc954
Compare
miri64
force-pushed
the
gnrc_sixlowpan_frag_sfr_congure_abe/feat/initial
branch
from
75bc954 to
cbb9711
Compare
Member
Author
|
Rebased and squashed to current master. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want me to ignore this issue, please mark it with the "State: don't stale" label. Thank you for your contributions. |
stale
bot
added
the
State: stale
miri64
removed
the
State: stale
miri64
force-pushed
the
gnrc_sixlowpan_frag_sfr_congure_abe/feat/initial
branch
from
cbb9711 to
c48a547
Compare
Member
Author
|
Rebased and adopted for current master and dependencies, needs #18798 though, for the test application to link. |
github-actions
bot
added
Area: build system
Contributor
|
Needs a rebase |
miri64
force-pushed
the
gnrc_sixlowpan_frag_sfr_congure_abe/feat/initial
branch
from
c48a547 to
26ab70a
Compare
github-actions
bot
removed
Area: doc
Member
Author
|
Rebased to current master and #16170. |
miri64
force-pushed
the
gnrc_sixlowpan_frag_sfr_congure_abe/feat/initial
branch
from
26ab70a to
690df90
Compare
Member
Author
|
Rebased again, to resolve merge conflicts caused by merging #16159 |
miri64
force-pushed
the
gnrc_sixlowpan_frag_sfr_congure_abe/feat/initial
branch
from
690df90 to
1cff487
Compare
miri64
added
CI: ready for build
Member
Author
|
The last rebase. |
benpicco
approved these changes
Mar 1, 2023
Member
Author
|
bors merge |
Contributor
|
Build succeeded: |
Member
Author
|
Finally the CC support for SFR is fully merged 🎉 Thanks @benpicco for reviewing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
This provisions GNRC's 6LoWPAN SFR implementation with the CongURE implementation of TCP Reno. It also adds that implementation to the
tests/gnrc_sixlowpan_frag_sfr_congure_impltest application.Testing procedure
The test
tests/gnrc_sixlowpan_frag_sfr_congure_implwhere extended to supportcongure_abe:Ping some nodes with at least 1 hop separation with large payloads. Exchange between should work.
Running the tests with
CONGURE_IMPL=congure_renoalso should still work.Issues/PRs references
Depends on
#15968(merged) and #16170 and their respective dependencies.