makefiles.kconfig.mk: use EXTERNAL_MODULE_DIRS in Kconfig resolution#17596
Merged
leandrolanzieri merged 2 commits intoRIOT-OS:masterfrom Feb 1, 2022
Merged
Conversation
Using EXTERNAL_MODULE_PATHS works fine when only using Kconfig for configuratio, but when using it for dependencies this value is not set since it depends on Kconfig. Instead use EXTERNAL_MODULE_DIRS and filter matching on Kconfig files.
fjmolinas
requested review from
MichelRottleuthner,
aabadie,
cgundogan,
jia200x and
smlng
as code owners
github-actions
bot
added
Area: build system
3 tasks
fjmolinas
force-pushed
the
pr_external_module_deps_kconfig
branch
from
0ac3b45 to
de325cd
Compare
fjmolinas
added
the
CI: ready for build
leandrolanzieri
added
Reviewed: 1-fundamentals
leandrolanzieri
added
the
Type: bug
Contributor
Author
|
Thanks @leandrolanzieri! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
While testing and reviewing #16104 I did not realize that although it worked for Kconfig configurations it would not work for dependencies. This was caught thanks to @NikLeberg I #17211, this PR fixes that.
Testing procedure
A test case for the dependencies was as well added to
tests/kconfig, the tests should succeed and configurations and dependencies are visible:Issues/PRs references
Follow up to #16104