sys,examples,tests,fuzzing: add missing includes #17714
Merged
fjmolinas merged 6 commits intoRIOT-OS:masterfrom Mar 1, 2022
Merged
sys,examples,tests,fuzzing: add missing includes #17714fjmolinas merged 6 commits intoRIOT-OS:masterfrom
fjmolinas merged 6 commits intoRIOT-OS:masterfrom
Conversation
kfessel
requested review from
MichelRottleuthner,
PeterKietzmann,
aabadie,
cgundogan,
fjmolinas,
haukepetersen,
leandrolanzieri,
maribu,
miri64 and
smlng
as code owners
github-actions
bot
added
Area: examples
This was referenced Feb 28, 2022
kfessel
added
the
CI: ready for build
fjmolinas
approved these changes
Mar 1, 2022
Contributor
fjmolinas
left a comment
fjmolinas
left a comment
There was a problem hiding this comment.
ACK, just header cleanups
benpicco
reviewed
Mar 1, 2022
| #include "mbox.h" | ||
| #include "net/af.h" | ||
| #include "net/gnrc.h" | ||
| #include "net/gnrc/tcp.h" |
Contributor
There was a problem hiding this comment.
Now this breaks the sock TCP example
net/sock/tcp.h is supposed to include sock_types.h which is then a stack specific header.
Unfortunately we don't have a sock tcp application to catch this on CI.
Contributor
Author
There was a problem hiding this comment.
sorry, good that you cought it and fixed it with #16723, which will also be a good check to avoid this happening again
Contributor
There was a problem hiding this comment.
tbh I thought #16739 would be less controversial way to get a (compile) test for a generic sock TCP but turns out that was not as easy as I thought
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
a huge examples and tests, some sys-modules and fuzzing/gnrc use functions of xtimer, gnrc(/nteif), without including the header, this PR adds these includes.
Testing procedure
reading
Murdock
build them
Issues/PRs references
was found while working on #17693