shell_cmd_gnrc_udp: add missing netutils dependency#18798
Merged
maribu merged 1 commit intoRIOT-OS:masterfrom Oct 25, 2022
Merged
shell_cmd_gnrc_udp: add missing netutils dependency#18798maribu merged 1 commit intoRIOT-OS:masterfrom
maribu merged 1 commit intoRIOT-OS:masterfrom
Conversation
The `gnrc_udp` shell command uses the function `netutils_get_ipv6()` but does not include the corresponding module `netutils`. The only reason most applications that use `shell_cmd_gnrc_udp` link is because they also include the `shell_cmd_gnrc_icmpv6_echo` module (e.g. implicit via `gnrc_ipcmpv6_echo`), which includes this dependency.
miri64
added
the
Type: bug
miri64
added
the
CI: ready for build
benpicco
approved these changes
Oct 25, 2022
benpicco
added
the
Impact: minor
Murdock results✔️ PASSED 149aadc shell_cmd_gnrc_udp: add missing netutils dependency
ArtifactsThis only reflects a subset of all builds from https://ci-prod.riot-os.org. Please refer to https://ci.riot-os.org for a complete build for now. |
This was referenced Oct 25, 2022
maribu
added
the
Process: needs backport
kaspar030
added
CI: ready for build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
The
gnrc_udpshell command uses the functionnetutils_get_ipv6()but does not include the corresponding modulenetutils. The only reason most applications that useshell_cmd_gnrc_udplink is because they also include theshell_cmd_gnrc_icmpv6_echomodule (e.g. implicit viagnrc_ipcmpv6_echo), which includes this dependency.Testing procedure
Remove the
gnrc_icmpv6_echomodule fromexamples/gnrc_networking:Now try to build this application for a platform of your choice. On current master, it will fail to link:
with this PR, it will link again.
Issues/PRs references
Noticed while trying to port the test of #16158 to using
shell_cmd_gnrc_udp.