cpu/lpc1768: add gpio peripheral (+ board adaptions) by basilfx · Pull Request #6472 · RIOT-OS/RIOT

basilfx · 2017-01-24T19:46:12Z

I needed GPIO on the LPC1768 (more specific, on the Seeeduino Arch Pro), but I realized it wasn't there. Since I need it for a demo tomorrow, I decided to add it :-)

So far output mode works, but that's all I tested. Have to dig into interrupts, which seem to be a bit more complex.

Adapted mbed_lpc1768 and seeeduino-arch_pro boards, including SAUL support for GPIO. I realize that they overlap a lot, but the boards are not quite similar.

WIP, needs a lot of cleanup.

aabadie · 2017-03-01T07:41:19Z

is this still works in progress @basilfx ?

aabadie

ping @basilfx

I tested on a mbed_lpc1768 board : the leds are inverted.

aabadie · 2017-02-02T21:53:57Z

boards/mbed_lpc1768/board.c

- * - LED2: P1.20
- * - LED3: P1.21
- * - LED4: P1.23
+ * @brief Initialize the boards on-board LEDs.


"boards on-board" => on-board is enough

aabadie · 2017-02-02T22:06:04Z

boards/seeeduino_arch-pro/include/board.h

-#define LED3_ON             (LED_PORT->FIOCLR  = LED3_MASK)
-#define LED3_OFF            (LED_PORT->FIOSET  = LED3_MASK)
-#define LED3_TOGGLE         (LED_PORT->FIOPIN ^= LED3_MASK)
+#define LED0_ON             gpio_clear(LED0_PIN)


Why not keeping the previous defines ?

I prefer to keep implementation in one place (gpio.c), and not having two different ways to toggle a LED.

aabadie · 2017-02-02T22:07:23Z

cpu/lpc1768/periph/gpio.c

+{
+    LPC_GPIO_TypeDef *base = _base(pin);
+
+    if (base->FIOSET & _pin(pin)) {


I think this can be done in one line using

base->FIOPIN ^= (1 << _pin(pin));

aabadie · 2017-02-02T22:09:11Z

boards/seeeduino_arch-pro/board.c

- * - LED4: P1.23
- *
- * The LEDs are active-low (current-sink).
+ * @brief Initialize the boards on-board LEDs.


same comment about on-board leds

aabadie · 2017-03-24T14:29:53Z

boards/mbed_lpc1768/include/board.h

-#define LED3_ON             (LED_PORT->FIOSET  = LED3_MASK)
-#define LED3_OFF            (LED_PORT->FIOCLR  = LED3_MASK)
-#define LED3_TOGGLE         (LED_PORT->FIOPIN ^= LED3_MASK)
+#define LED0_ON             gpio_clear(LED0_PIN)


Looks like this is inverted.

Fixed.

On the Seeeduino Arch-Pro, they are inverted :-)

aabadie · 2017-04-05T15:29:32Z

ping @basilfx

basilfx · 2017-04-05T15:46:14Z

@aabadie Sorry, I'm very busy with work-work. Will have to wait.

aabadie · 2017-06-20T18:14:59Z

ping @basilfx. Any chance to apply the requested changes for the next release ?

aabadie · 2018-01-05T09:24:17Z

@basilfx any chance for this one to be ready for the release ?

basilfx · 2018-03-30T22:20:41Z

@aabadie I finally found the time to fix this one.

Re-implemented the GPIO driver, added support for interrupts and fixed board LEDs.

aabadie

Looks good codewise, just a minor thing.

Otherwise, I tested it and it works now. Well done !

aabadie · 2018-04-03T06:51:48Z

boards/seeeduino_arch-pro/Makefile.include

 DEBUG_ADAPTER ?= dap

 # this board uses openocd
+export IMAGE_FILE = $(HEXFILE)


Looks unrelated. Maybe #8845 will help ?

It's needed to flash the HEX file instead of the ELF file. #8845 would help, yes.

I would prefer to make this change in a separate PR. Is it ok for you ?

I'll put this in another PR.

Created #8866.

aabadie

#8866 is merged, please rebase and squash.

ACK

basilfx · 2018-04-03T11:31:59Z

Rebased and squashed.

basilfx · 2018-04-03T15:06:33Z

Murdock is happy!

PeterKietzmann added Platform: ARM Platform: This PR/issue effects ARM-based platforms Area: drivers Area: Device drivers State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet labels Jan 25, 2017

PeterKietzmann assigned haukepetersen and aabadie Jan 25, 2017

aabadie requested changes Mar 24, 2017

View reviewed changes

aabadie modified the milestones: Release 2017.07, Release 2017.10 Jun 26, 2017

smlng modified the milestones: Release 2017.10, Release 2018.01 Nov 16, 2017

smlng removed this from the Release 2018.01 milestone Jan 12, 2018

MrKevinWeiss mentioned this pull request Mar 23, 2018

periph: remove dev_enums.h #7941

Closed

7 tasks

basilfx force-pushed the feature/lpc1768_gpio branch from af263b6 to d8f7a1d Compare March 30, 2018 22:18

basilfx removed the State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet label Mar 30, 2018

basilfx added CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Mar 30, 2018

basilfx changed the title ~~cpu/lpc1768: add gpio peripheral (+ board adaptions) (WIP)~~ cpu/lpc1768: add gpio peripheral (+ board adaptions) Mar 31, 2018

aabadie requested changes Apr 3, 2018

View reviewed changes

basilfx mentioned this pull request Apr 3, 2018

boards: seeeduino_arch-pro: use hex file. #8866

Merged

aabadie approved these changes Apr 3, 2018

View reviewed changes

basilfx force-pushed the feature/lpc1768_gpio branch from a50c6e3 to 18e6e5c Compare April 3, 2018 11:31

basilfx removed the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Apr 3, 2018

basilfx force-pushed the feature/lpc1768_gpio branch from 18e6e5c to ceb8487 Compare April 3, 2018 14:13

basilfx added 3 commits April 3, 2018 16:47

cpu: lpc1768: implement gpio driver

6be31d1

boards: mbed_lpc1768: adapt to gpio driver.

c99c07a

boards: seeeduino_arch-pro: adapt to gpio driver.

29b3798

basilfx force-pushed the feature/lpc1768_gpio branch from ceb8487 to 29b3798 Compare April 3, 2018 14:48

basilfx merged commit 77ad70e into RIOT-OS:master Apr 3, 2018

basilfx deleted the feature/lpc1768_gpio branch January 14, 2020 22:02

Conversation

basilfx commented Jan 24, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aabadie commented Mar 1, 2017

Uh oh!

aabadie left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aabadie commented Apr 5, 2017

Uh oh!

basilfx commented Apr 5, 2017

Uh oh!

aabadie commented Jun 20, 2017

Uh oh!

aabadie commented Jan 5, 2018

Uh oh!

basilfx commented Mar 30, 2018

Uh oh!

aabadie left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aabadie left a comment

Choose a reason for hiding this comment

Uh oh!

basilfx commented Apr 3, 2018

Uh oh!

basilfx commented Apr 3, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

basilfx commented Jan 24, 2017 •

edited

Loading