boards: seeeduino_arch-pro: use hex file.#8866
Merged
aabadie merged 1 commit intoRIOT-OS:masterfrom Apr 3, 2018
Merged
Conversation
basilfx
added
Type: bug
aabadie
approved these changes
Apr 3, 2018
Contributor
aabadie
left a comment
aabadie
left a comment
There was a problem hiding this comment.
Untested-ACK
This was working before, but somewhere it broke
It would be great to find the reason.
Member
Author
I had an old RIOT clone (april 2017) that worked, and after rebasing it didn't. So I think that the OpenOCD refactoring (october 2017 IIRC) caused it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
LPC1768 needs a checksum inserted, which is not performed by OpenOCD. I use
lpc_checksumfor that, which requires a HEX file instead of an ELF or BIN file.This was working before, but somewhere it broke. This PR ensures that the HEX file is used when inserting the checksum.
Issues/PRs references
#6472