Skip to content

Makefile.include: FIX .DEFAULT_GOAL not being all#8846

Merged
kaspar030 merged 3 commits intoRIOT-OS:masterfrom
cladmi:pr/make/default_goal
Mar 28, 2018
Merged

Makefile.include: FIX .DEFAULT_GOAL not being all#8846
kaspar030 merged 3 commits intoRIOT-OS:masterfrom
cladmi:pr/make/default_goal

Conversation

@cladmi
Copy link
Contributor

@cladmi cladmi commented Mar 28, 2018

Contribution description

.DEFAULT_GOAL is reset many times which removed 'all' from being the default goal.
By chance it was then set to link so was working by luck.

When I added an elffile goal in #8845 the default changed for it which is more problematic.

Output with buildtest error shown with only the assert commit.

make -C examples/hello-world/  buildtest | grep -v success
make: Entering directory '/home/harter/work/git/RIOT/examples/hello-world'
/home/harter/work/git/RIOT/examples/hello-world/../../Makefile.include:595: *** .DEFAULT_GOAL := link.  Stop.
Building for arduino-duemilanove ... failed!
/home/harter/work/git/RIOT/examples/hello-world/../../Makefile.include:595: *** .DEFAULT_GOAL := link.  Stop.
Building for arduino-mega2560 ... failed!
/home/harter/work/git/RIOT/examples/hello-world/../../Makefile.include:595: *** .DEFAULT_GOAL := link.  Stop.
Building for arduino-uno ... failed!
/home/harter/work/git/RIOT/examples/hello-world/../../Makefile.include:595: *** .DEFAULT_GOAL := link.  Stop.
Building for avsextrem ... failed!
/home/harter/work/git/RIOT/examples/hello-world/../../Makefile.include:595: *** .DEFAULT_GOAL := link.  Stop.
Building for chronos ... failed!
/home/harter/work/git/RIOT/examples/hello-world/../../Makefile.include:595: *** .DEFAULT_GOAL := link.  Stop.
Building for jiminy-mega256rfr2 ... failed!
/home/harter/work/git/RIOT/examples/hello-world/../../Makefile.include:595: *** .DEFAULT_GOAL := link.  Stop.
Building for mega-xplained ... failed!
There are unsatisfied feature requirements: periph_uart


EXPECT ERRORS!


/home/harter/work/git/RIOT/examples/hello-world/../../Makefile.include:595: *** .DEFAULT_GOAL := link.  Stop.
Building for mips-malta ... failed!
/home/harter/work/git/RIOT/examples/hello-world/../../Makefile.include:595: *** .DEFAULT_GOAL := link.  Stop.
Building for msb-430 ... failed!
/home/harter/work/git/RIOT/examples/hello-world/../../Makefile.include:595: *** .DEFAULT_GOAL := link.  Stop.
Building for msb-430h ... failed!
/home/harter/work/git/RIOT/examples/hello-world/../../Makefile.include:595: *** .DEFAULT_GOAL := link.  Stop.
Building for msba2 ... failed!
e/home/harter/work/git/RIOT/examples/hello-world/../../Makefile.include:595: *** .DEFAULT_GOAL := link.  Stop.
Building for pic32-clicker ... failed!
/home/harter/work/git/RIOT/examples/hello-world/../../Makefile.include:595: *** .DEFAULT_GOAL := link.  Stop.
Building for pic32-wifire ... failed!
/home/harter/work/git/RIOT/examples/hello-world/../../Makefile.include:595: *** .DEFAULT_GOAL := link.  Stop.
Building for telosb ... failed!
/home/harter/work/git/RIOT/examples/hello-world/../../Makefile.include:595: *** .DEFAULT_GOAL := link.  Stop.
Building for waspmote-pro ... failed!
/home/harter/work/git/RIOT/examples/hello-world/../../Makefile.include:595: *** .DEFAULT_GOAL := link.  Stop.
Building for wsn430-v1_3b ... failed!
/home/harter/work/git/RIOT/examples/hello-world/../../Makefile.include:595: *** .DEFAULT_GOAL := link.  Stop.
Building for wsn430-v1_4 ... failed!
/home/harter/work/git/RIOT/examples/hello-world/../../Makefile.include:595: *** .DEFAULT_GOAL := link.  Stop.
Building for z1 ... failed!
make: *** [buildtest] Error 1
/home/harter/work/git/RIOT/makefiles/buildtests.inc.mk:7: recipe for target 'buildtest' failed
make: Leaving directory '/home/harter/work/git/RIOT/examples/hello-world'

Issues/PRs references

Required for #8845

cladmi added 2 commits March 28, 2018 16:59
@cladmi
Makefile.include: FIX .DEFAULT_GOAL not being all
fff5810 
.DEFAULT_GOAL was reset many times which removed 'all' from being the default
goal.
By chance it was then set to `link` so was working by some magic.
@cladmi
Makefile.include: add an assert that .DEFAULT_GOAL is all
9253523
@cladmi cladmi added Area: build system Area: Build system Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Mar 28, 2018
@cladmi cladmi mentioned this pull request Mar 28, 2018
Merged
kaspar030
kaspar030 approved these changes Mar 28, 2018
View reviewed changes
Copy link
Contributor

@kaspar030 kaspar030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.

@kaspar030 kaspar030 merged commit 8060f55 into RIOT-OS:master Mar 28, 2018
@jnohlgard
Copy link
Member

jnohlgard commented Mar 28, 2018

@cladmi nice! Thanks for cleaning up the build system

@cladmi cladmi deleted the pr/make/default_goal branch March 28, 2018 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kaspar030 kaspar030 kaspar030 approved these changes

Assignees

No one assigned

Labels

Area: build system Area: Build system CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation

Projects

None yet

Milestone

Release 2018.04

Development

Successfully merging this pull request may close these issues.

3 participants

@cladmi @jnohlgard @kaspar030