Skip to content

Makefile.include: add %.hex and %.bin rules#8845

Merged
kaspar030 merged 4 commits intoRIOT-OS:masterfrom
cladmi:pr/make/add_hex_bin_rules
Apr 9, 2018
Merged

Makefile.include: add %.hex and %.bin rules#8845
kaspar030 merged 4 commits intoRIOT-OS:masterfrom
cladmi:pr/make/add_hex_bin_rules

Conversation

@cladmi
Copy link
Contributor

@cladmi cladmi commented Mar 28, 2018 •
edited
Loading

Contribution description

  • Replace HEXFILE rule by a rule for each type.
  • Add BINFILE variable
  • Add 'elffile', 'hexfile' and 'binfile' named targets
  • Cleanup of OFLAGS from -Oformat

Issues/PRs references

Depends on #8844 #8846
Part of #8838

@cladmi cladmi added Area: build system Area: Build system Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation State: waiting for other PR State: The PR requires another PR to be merged first CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Mar 28, 2018
@cladmi
Copy link
Contributor Author

cladmi commented Mar 28, 2018

When testing locally, I found out that mips-malta is broken with this as it was doing an objcopy without arguments before. Will fix.

However, I also found that the default goal is not all anymore for some boards, it was link but now its elffile so it does not fail when you do make BOARD=mips-malta.

I will do another PR for the second one.

This was referenced Mar 28, 2018
Merged
Merged
@cladmi cladmi force-pushed the pr/make/add_hex_bin_rules branch from b86df3c to dba45b8 Compare March 28, 2018 17:32
@aabadie aabadie mentioned this pull request Apr 3, 2018
Merged
@kaspar030
Copy link
Contributor

kaspar030 commented Apr 9, 2018

please squash

@cladmi cladmi force-pushed the pr/make/add_hex_bin_rules branch from dba45b8 to fe8f4d1 Compare April 9, 2018 14:58
@cladmi cladmi removed the State: waiting for other PR State: The PR requires another PR to be merged first label Apr 9, 2018
cladmi and others added 4 commits April 9, 2018 17:32
@cladmi
mips-malta: fix 'HEXFILE' generation to binfile
42d1e1a 
OBJCOPY was called without arguments so only copied the elffile in a file named
.hex.
Cannot build an '.hex' file for mips-malta so use a .bin output.
@cladmi
Makefile.include: add %.hex and %.bin rules
70c5079 
Replace HEXFILE rule by a rule for each type.
HACK: Adding '-Oformat' after OFLAGS overwrite the value in flags.
@cladmi
Makefile.include: add targets to get .elf/.bin/.hex
ae5e883
@cladmi
boards/makefiles: Remove '-Otype' from OFLAGS
3f14541 
* Remove '-Oihex' and '-Obinary' from OFLAGS for all boards
  It is now provided by the Makefile.include rule.
@cladmi cladmi force-pushed the pr/make/add_hex_bin_rules branch from fe8f4d1 to 3f14541 Compare April 9, 2018 15:33
@kaspar030 kaspar030 added CI: run tests If set, CI server will run tests on hardware for the labeled PR CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Apr 9, 2018
@cladmi cladmi mentioned this pull request Apr 9, 2018
Merged
@kaspar030
Copy link
Contributor

kaspar030 commented Apr 9, 2018

murdock failure is unrelated.

@kaspar030 kaspar030 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: run tests If set, CI server will run tests on hardware for the labeled PR CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Apr 9, 2018
kaspar030
kaspar030 approved these changes Apr 9, 2018
View reviewed changes
Copy link
Contributor

@kaspar030 kaspar030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.

@kaspar030 kaspar030 merged commit 7b64863 into RIOT-OS:master Apr 9, 2018
@cladmi cladmi deleted the pr/make/add_hex_bin_rules branch April 9, 2018 16:29
@cladmi cladmi added this to the Release 2018.04 milestone Nov 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kaspar030 kaspar030 kaspar030 approved these changes

Assignees

No one assigned

Labels

Area: build system Area: Build system CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation

Projects

None yet

Milestone

Release 2018.04

Development

Successfully merging this pull request may close these issues.

2 participants

@cladmi @kaspar030