Conversation
9f6a934 to
278bc15
Compare
|
Fixed an alignment issue with the initialization code on Cortex-M0 |
2d6ac65 to
d40d9d2
Compare
|
To simplify reviewing, can you put in the commit message a link to the file you used a reference? |
|
I don't have a link unfortunately, I used |
|
I started reviewing by getting the default one and modifying it to look like our own to help me reviewing, I will try something next week in this direction. My goal is to really show what is needed for RIOT which is not in the default one. So adding commits before that adds the default ldscript and adapts it before replacing our own. Question, I first changed the indentation of the default ldscript to our own, I could do the opposite to really see the what are our required modifications from the default. Which way would you prefer ? Keeping our style or adopting the original one ? To simplify comparing versions with mine, could you squash the changes that are not ". = ALIGN(4)" related ? |
d40d9d2 to
704b56a
Compare
|
@cladmi I inserted a commit with the default ldscript before the RIOT specific changes to make this easier to review. |
…ar to binutils default
…e similar to binutils default
704b56a to
0688e88
Compare
|
rebased and addressed build failures |
|
@gebart I am not forgetting it, no worry :) But it is I think "only" for xfa #9105 that also needs So my current pipeline for this was more If you would like to have it before |
|
I should have given updates here though, I am bad at this. |
|
@cladmi sorry, I think I must have been mixed up the dependencies as well. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want me to ignore this issue, please mark it with the "State: don't stale" label. Thank you for your contributions. |
Contribution description
This is a rewrite of the cortexm_base ldscript to make it more similar to the default ldscripts for native and other platforms. Sections which do not need a runtime relocation (e.g. .text, .bss), except for some special cases (.preinit_array, .init_array, .fini_array etc.) do not need to have a output segment specified, as long as the attribute flags are set properly on the memory segments (#9089).
Issues/PRs references
based on #9089