make/flash: make flasher take the file used for flashing from command line argument

[cladmi]

Contribution description

This makes most of the boards get the file used for flashing from command line arguments instead of environment variables. This prevents using arbitrary "HEXFILE" or "BINFILE".

This is a split of #8838 that already have been tested.

I split it to allow only fixing newly added boards before adding the FLASHFILE variable.

Issues/PRs references

Split of #8838

[cladmi]

Updated the reference in the PR that was wrong.

[smlng]

I'm a bit confused when to use (and why) HEXFILE or BINFILE it looks a bit random to me, can you explain, eg. for the different flash script eg. cc2538 vs. calliope.

[smlng]

for the calliope you specified HEXFILE=$1

[cladmi]

I based myself on what file is actually used by the board:

make --no-print-directory -C examples/hello-world/ info-debug-variable-HEXFILE  BOARD=calliope-mini
.../examples/hello-world/bin/calliope-mini/hello-world.hex
make --no-print-directory -C examples/hello-world/ info-debug-variable-HEXFILE  BOARD=mbed_lpc1768
.../examples/hello-world/bin/mbed_lpc1768/hello-world.bin

The mbed board uses BINFILE as file to generate called HEXFILE currently

RIOT/boards/mbed_lpc1768/Makefile.include

Line 8 in 746d3e1

HEXFILE = $(BINFILE)

[smlng]

ah so you want to match the variable name in the script with the actual file ending, right? So BINFILE where it is <appname>.bin and HEXFILE for <appname>.hex. Makes sense, was just confusing to use different variable names inside all those flash scripts.

[cladmi]

I tried to be coherent with the filename/extension yes.

[cladmi]

I can definitely split this PR if it helps you review (and maybe merge :)) separately.
If it is the case, please tell me how you want the split.

[cladmi]

Rebased to remove merge conflict with jlink.sh.

[smlng]

No need to split this further, just needed some clarification

[kYc0o]

Is this ready then?

[cladmi]

I think it is ready but it is still only a subset of all the boards.

I could still split to allow testing only few boards at a time and get the fix merged.

[cladmi]

This PR is getting split with references in the original PR: #8838

[aabadie]

@cladmi, please rebase this PR.

[cladmi]

I am splitting openocd out of this one to have a proper testing procedure. (writing in process)

[cladmi]

Split in #10539

[cladmi]

All the split boards were either merged or split outside now, so I close this one.