Do not count multiple reviews from the same user

[chrysn]

My two ACKs (long apart, second reaffirming) were counted as two in RIOT-OS/RIOT#18942 for where two ACKs would have been needed.

I've added the mock by how I read https://pygithub.readthedocs.io/en/stable/github_objects/PullRequestReview.html and https://docs.github.com/en/rest/pulls/reviews?apiVersion=2022-11-28, is there any good way to confirm that .login is really a field access?

[chrysn]

For lack of rights to assign @miri64, pinging instead. Does this repo require extra privileges to kick off actions as well?

[miri64]

is there any good way to confirm that .login is really a field access?

I just tested it in the console for RIOT-OS/RIOT#20647 (which has three reviews):

In [1]: import github

In [2]: repo = github.Github("ghp_xxxxxxxxxxxxxxxxxxxxx").get_rep
   ...: o("RIOT-OS/RIOT")

In [3]: pull = repo.get_pull(20647)

In [4]: for review in pull.get_reviews():
   ...:     print(review.user.login)
   ...: 
mguetschow
dylad
Teufelchen1

[miri64]

repo = github.Github("ghp_xxxxxxxxxxxxxxxxxxxxx").get_rep
...: o("RIOT-OS/RIOT")

Wow Github is smart :D accidentally posted the token and immediately it was revoked.

[miri64]

Code looks good and tests are passing. ACK!

[miri64]

Does this repo require extra privileges to kick off actions as well?

Could you try to rebase? :-/

[chrysn]

Nothing to rebase; commit--amend'ed and force pushed for the desired effect, CI now running.

[codecov-commenter]

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

[miri64]

Just use black ;-)

[chrysn]

Force pushed a single lint fix ("expected 1 blank line before a nested definition, found 0"), the others might be still showing but be on some ignore list (I didn't touch the overly long lines).

If they show up again, I'll do the needful in a separate cleanup commit.

[miri64]

See #3 for the yield from issue.

[chrysn]

Just use black ;-)

I did, and it was happy. Apparently, linters disagree with each other.

I'll fix this one manually, but urge you to stop making styling mandatory where the auto-indent tools don't fix things.

[miri64]

I did, and it was happy. Apparently, linters disagree with each other.

Black does not honor line lengths for strings.

I'll fix this one manually, but urge you to stop making styling mandatory where the auto-indent tools don't fix things.

I provided suggestions

[miri64]

Removed the requirement for the commits to be signed.