Dockerfile: add missing Openthread dependencies#48
Merged
jnohlgard merged 2 commits intoRIOT-OS:masterfrom Oct 5, 2018
Merged
Conversation
|
@miri64 Please review this PR. This is crucial to merge OpenThread. |
Member
|
LGTM, but I am not very experienced with docker and I'm not sure about the MIPS toolchain change... @cladmi can you have a look? |
Member
Contributor
|
I tested RIOT-OS/RIOT#9336 and it indeed fails with the current image. |
jia200x
force-pushed
the
pr/openthread_dependencies
branch
from
85a9e40 to
91bc28a
Compare
Member
Author
Contributor
|
Compiling worked with the branch before rebase. Could you add in the commits message body why you add the dependency ? |
Member
|
Looks fine to go |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
libtoolandm4, required for building OpenThread.I tried to build OpenThread with and without this PR, and this fixes the issue.
It was rebased into #47Since #50 got merged, this should work now!