Open
Conversation
added 2 commits
February 21, 2026 05:40
smurokh
reviewed
Feb 24, 2026
src/igvc_cv/igvc_cv/cv_node.py
Outdated
| def image_callback(self, msg): | ||
| frame = self.bridge.imgmsg_to_cv2(msg, 'bgr8') | ||
| gray = cv2.cvtColor(frame, cv2.COLOR_BGR2GRAY) | ||
| blur = cv2.GaussianBlur(gray, (11, 11), 33, 33) |
There was a problem hiding this comment.
The arguments of the GaussianBlur function (as well as the Canny and HoughLinesProbability) will be adjusted in the future based on our actual camera image and testing. Would it be better to have them as arguments in this function or will they be manually edited in the code?
smurokh
requested changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added CV ROS2 Node