[MOD-10654] [MOD-10694] Enhance SVS Debug Info Iterator #736
+403
−249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make them more general remove "HNSW" indicator from: - HNSW_NUM_MARKED_DELETED - HNSW_EPSILON_STRING elaborate vec_utils with the new SVS strings, and *_ToString functions update svs and multi svs tests
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #736 +/- ##
==========================================
+ Coverage 96.82% 96.85% +0.02%
==========================================
Files 122 122
Lines 7443 7498 +55
==========================================
+ Hits 7207 7262 +55
Misses 236 236 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Add missing SVS-specific fields to compareSVSIndexInfoToIterator function - Create scoped field count constants for all index types (FLAT, HNSW, SVS, TIERED) - Unify tiered index testing with generic compareTieredIndexInfoToIterator - Fix VecSimBool enum definition and backgroundIndexing field type consistency - Add SVS tiered-specific debug fields (training threshold, update threshold, timeout)
fix tierred in svs
meiravgri
changed the title
meiravgri
changed the title
lerman25
reviewed
Aug 6, 2025
src/VecSim/algorithms/svs/svs.h
Outdated
| return info; | ||
| } | ||
|
|
||
| VecSimDebugInfoIterator *debugInfoIterator() const override { | ||
| VecSimIndexDebugInfo info = this->debugInfo(); | ||
| // For readability. Update this number when needed. | ||
| size_t numberOfInfoFields = 10; | ||
| size_t numberOfInfoFields = 24; |
There was a problem hiding this comment.
There must be a better way
Maybe not for this PR
There was a problem hiding this comment.
its just an optiomisation to avoid vector reallocation. if the number doesn't exactly match the number of fields the vector will increase its capacity.
src/VecSim/algorithms/svs/svs.h
Outdated
Comment on lines
367
to
371
| .searchWindowSize = this->search_window_size, | ||
| .searchBufferCapacity = this->search_buffer_capacity, | ||
| .leanvecDim = this->leanvec_dim, | ||
| .epsilon = this->epsilon}; | ||
| .epsilon = this->epsilon, | ||
| .changes_num = this->changes_num}; |
There was a problem hiding this comment.
number of marked deleted and changes num are the same?
There was a problem hiding this comment.
good catch :)
they are
There was a problem hiding this comment.
- currently
"// Count severe index changes (currently deletions only) and consolidate index if needed"
lerman25
previously approved these changes
Aug 6, 2025
lerman25
approved these changes
Aug 7, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Aug 7, 2025
* expose svs info via iterator in debugInfoIterator To make them more general remove "HNSW" indicator from: - HNSW_NUM_MARKED_DELETED - HNSW_EPSILON_STRING elaborate vec_utils with the new SVS strings, and *_ToString functions update svs and multi svs tests * Enhance SVS debug info iterator with complete field validation - Add missing SVS-specific fields to compareSVSIndexInfoToIterator function - Create scoped field count constants for all index types (FLAT, HNSW, SVS, TIERED) - Unify tiered index testing with generic compareTieredIndexInfoToIterator - Fix VecSimBool enum definition and backgroundIndexing field type consistency - Add SVS tiered-specific debug fields (training threshold, update threshold, timeout) * info.tieredInfo.backgroundIndexing = fix tierred in svs * fix hnsw tiered backgroudhnindxxing * remove VecSimBool_ToString, not needed * remove num_threads * add coverage * fi field count * fix wuant bits * fix tests (cherry picked from commit d545769)
|
Successfully created backport PR for |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 7, 2025
[MOD-10654] [MOD-10694] Enhance SVS Debug Info Iterator (#736) * expose svs info via iterator in debugInfoIterator To make them more general remove "HNSW" indicator from: - HNSW_NUM_MARKED_DELETED - HNSW_EPSILON_STRING elaborate vec_utils with the new SVS strings, and *_ToString functions update svs and multi svs tests * Enhance SVS debug info iterator with complete field validation - Add missing SVS-specific fields to compareSVSIndexInfoToIterator function - Create scoped field count constants for all index types (FLAT, HNSW, SVS, TIERED) - Unify tiered index testing with generic compareTieredIndexInfoToIterator - Fix VecSimBool enum definition and backgroundIndexing field type consistency - Add SVS tiered-specific debug fields (training threshold, update threshold, timeout) * info.tieredInfo.backgroundIndexing = fix tierred in svs * fix hnsw tiered backgroudhnindxxing * remove VecSimBool_ToString, not needed * remove num_threads * add coverage * fi field count * fix wuant bits * fix tests (cherry picked from commit d545769) Co-authored-by: meiravgri <109056284+meiravgri@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements comprehensive debug info iterator for SVS indexes and fixes background indexing status for tiered indexes.
Key Changes
Technical Details
Increased SVS debug iterator
Changed backgroundIndexing from bool to VecSimBool enum
Added utility functions: VecSimQuantBits_ToString()
Added tiered SVS-specific parameters (training/update thresholds, timeout)