Skip to content

[8.2] [MOD-10654] [MOD-10694] Enhance SVS Debug Info Iterator #739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 7, 2025

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Aug 7, 2025

Description

Backport of #736 to 8.2.

* expose svs info via iterator in debugInfoIterator

To make them more general remove "HNSW" indicator from:
- HNSW_NUM_MARKED_DELETED
- HNSW_EPSILON_STRING

elaborate vec_utils with the new SVS strings, and *_ToString functions

update svs and multi svs tests

* Enhance SVS debug info iterator with complete field validation

- Add missing SVS-specific fields to compareSVSIndexInfoToIterator function
- Create scoped field count constants for all index types (FLAT, HNSW, SVS, TIERED)
- Unify tiered index testing with generic compareTieredIndexInfoToIterator
- Fix VecSimBool enum definition and backgroundIndexing field type consistency
- Add SVS tiered-specific debug fields (training threshold, update threshold, timeout)

* info.tieredInfo.backgroundIndexing =
fix tierred  in svs

* fix hnsw tiered backgroudhnindxxing

* remove VecSimBool_ToString, not needed

* remove num_threads

* add coverage

* fi field count

* fix wuant bits

* fix tests

(cherry picked from commit d545769)
@GuyAv46 GuyAv46 marked this pull request as draft August 7, 2025 12:42
@GuyAv46 GuyAv46 marked this pull request as ready for review August 7, 2025 12:42
@GuyAv46 GuyAv46 requested a review from meiravgri August 7, 2025 12:42
@meiravgri meiravgri enabled auto-merge August 7, 2025 12:44
Copy link

codecov bot commented Aug 7, 2025

Codecov Report

❌ Patch coverage is 98.43750% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 96.83%. Comparing base (0c0cbc9) to head (f009177).
⚠️ Report is 1 commits behind head on 8.2.

Files with missing lines Patch % Lines
src/VecSim/utils/vec_utils.cpp 94.73% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              8.2     #739      +/-   ##
==========================================
+ Coverage   96.81%   96.83%   +0.01%     
==========================================
  Files         122      122              
  Lines        7389     7448      +59     
==========================================
+ Hits         7154     7212      +58     
- Misses        235      236       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@meiravgri meiravgri added this pull request to the merge queue Aug 7, 2025
Merged via the queue into 8.2 with commit 1f1df26 Aug 7, 2025
17 checks passed
@meiravgri meiravgri deleted the backport-736-to-8.2 branch August 7, 2025 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant