Merged
Conversation
Owner
|
Wow! This looks very impressive! I'm unsure how much time I have this week so I might need a bit before Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the performances of the ui, as it takes a couple milliseconds with hundreds of logs.
Three things were implemented:
egui::ScrollArea::show_rowsto only add label for visible recordsThis is not very useful alone, as it needs to know the
n to n+krecords to display.To know this we currently need to compute the
LayoutJoband filter by search on it.So to make full use of it we cache the search results.
These two combined provide a 15x speedup improvement at low cost (only ony bool per record).
This is more memory intensive and thus is an option in the Ui now (enabled by default), but this brings another 30% improvement.
A benchmark example was added to the project to compare. On my computer with the benchmark, the curent release version with cache layout enabled runs in 2.100ms, while this PR runs in 0.100ms.
release
debug