js calc prt 1#2
Open
Denae716 wants to merge 1 commit intoReturn-Ready-2021-JavaScript-Evening:mainfrom
Open
Conversation
kburd
reviewed
Nov 12, 2020
| @@ -0,0 +1,31 @@ | |||
| .calculator_keys_standard { | |||
| <div class = "calculator"> | ||
| <div class = "calculator_display">0</div> | ||
| <div class = "calculator_keys_standard"> | ||
| <button style = "background-color: gainsboro">(</button> |
There was a problem hiding this comment.
Inline styling is ok, just use it sparingly
| <div class = "calculator"> | ||
| <div class = "calculator_display">0</div> | ||
| <div class = "calculator_keys_scientific"> | ||
| <button style = "background-color: gainsboro">Rad | Deg</button> |
There was a problem hiding this comment.
Based on your html, we will have to implement this button functionally as a toggle. More on that when we get back into JS
|
|
||
| h1 { | ||
| font-size: 20px; | ||
| } No newline at end of file |
There was a problem hiding this comment.
Buttons should have margin (-1)
Gray and blue buttons do not change color on hover (-5)
First column of light gray buttons showing up in wrong place. Take a look at how you set up your css grid layout (-1)
Great work! 93/100
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.