Skip to content

js calc prt 1 #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Denae716 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

js calc prt 1 #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 45 additions & 0 deletions scientific.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
<!DOCTYPE html>
<html>
<link rel = "stylesheet" href = "styles.css">
<h1><a href = standard.html>Standard</a> | Scientific</h1>
<div class = "calculator">
<div class = "calculator_display">0</div>
<div class = "calculator_keys_scientific">
<button style = "background-color: gainsboro">Rad | Deg</button>
Copy link
Copy Markdown

@kburd kburd Nov 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on your html, we will have to implement this button functionally as a toggle. More on that when we get back into JS

<button style = "background-color: gainsboro">x!</button>
<button style = "background-color: gainsboro">(</button>
<button style = "background-color: gainsboro">)</button>
<button style = "background-color: gainsboro">%</button>
<button style = "background-color: gainsboro">AC</button>
<button>Inv</button>
<button>Sin</button>
<button>In</button>
<button>7</button>
<button>8</button>
<button>9</button>
<button style = "background-color: gainsboro">/</button>
<button>&#960;</button>
<button>Cos</button>
<button>log</button>
<button>4</button>
<button>5</button>
<button>6</button>
<button style = "background-color: gainsboro">*</button>
<button>e</button>
<button>Tan</button>
<button>&#8730;</button>
<button>1</button>
<button>2</button>
<button>3</button>
<button style = "background-color: gainsboro">-</button>
<button>Ans</button>
<button>EXP</button>
<button>x<sup>y</sup></button>
<button>0</button>
<button>.</button>
<button style = "background-color: dodgerblue">=</button>
<button style = "background-color: gainsboro">+</button>
</div>
</div>

</html>
31 changes: 31 additions & 0 deletions standard.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
<!DOCTYPE html>
<html>
<link rel = "stylesheet" href = "styles.css">
<h1>Standard | <a href = scientific.html>Scientific</a></h1>
<div class = "calculator">
<div class = "calculator_display">0</div>
<div class = "calculator_keys_standard">
<button style = "background-color: gainsboro">(</button>
Copy link
Copy Markdown

@kburd kburd Nov 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inline styling is ok, just use it sparingly

<button style = "background-color: gainsboro">)</button>
<button style = "background-color: gainsboro">%</button>
<button style = "background-color: gainsboro">AC</button>
<button>7</button>
<button>8</button>
<button>9</button>
<button style = "background-color: gainsboro">/</button>
<button>4</button>
<button>5</button>
<button>6</button>
<button style = "background-color: gainsboro">*</button>
<button>1</button>
<button>2</button>
<button>3</button>
<button style = "background-color: gainsboro">-</button>
<button>0</button>
<button>.</button>
<button style = "background-color: dodgerblue">=</button>
<button style = "background-color: gainsboro">+</button>
</div>
</div>

</html>
31 changes: 31 additions & 0 deletions styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
.calculator_keys_standard {
Copy link
Copy Markdown

@kburd kburd Nov 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome use of css grid!!!

display: grid;
grid-template-columns: auto auto auto auto;
grid-template-rows: auto auto auto auto auto;

}

.calculator_keys_scientific {
display: grid;
grid-template-columns: auto auto auto auto auto auto auto;
grid-template-rows: auto auto auto auto auto;
grid: float;
}

.calculator {
border-style: solid;

}

.calculator_display {
position: right;
}

html {
max-width: 500px;
max-height: 500px;
}

h1 {
font-size: 20px;
}
Copy link
Copy Markdown

@kburd kburd Nov 12, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Buttons should have margin (-1)
Gray and blue buttons do not change color on hover (-5)
First column of light gray buttons showing up in wrong place. Take a look at how you set up your css grid layout (-1)

Great work! 93/100