Fix DingTalk stream group replies and ack flow#840
Open
xfei6868 wants to merge 1 commit intoRightNow-AI:mainfrom
Open
Fix DingTalk stream group replies and ack flow#840xfei6868 wants to merge 1 commit intoRightNow-AI:mainfrom
xfei6868 wants to merge 1 commit intoRightNow-AI:mainfrom
Conversation
Member
|
Reviewed and approved. This PR has merge conflicts with recent changes on main. Please rebase onto current main and we will merge it. |
6711059 to
0104238
Compare
Author
rebase it. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
• ## Summary
Improve DingTalk Stream reply behavior so group replies
stay in the original conversation, send an immediate
acknowledgment, and mention the asking user in group chats.
Changes
sessionWebhookinstead of sending group replies as one-to-one messages
Received, please wait.acknowledgmentfor incoming DingTalk Stream messages before agent
processing
atUserIdsfor reply routing and mention handling, including
sessionWebhook,isInAtList, and sender identitymetadata
parsing and session reply payload generation
Testing
cargo clippy --workspace --all-targets -- -D warningspassescargo test --workspacepassesAdditional verification:
cargo test -p openfang-channels dingtalk_stream -- --nocapturepassesdingtalk_streamstarts andconnects successfully
Security