⚡ Bolt: [performance improvement] Consolidate closure status queries

[RohanExploit]

💡 What:
Replaced two separate COUNT queries on the ClosureConfirmation table with a single GROUP BY query in the get_closure_status endpoint (backend/routers/grievances.py).

🎯 Why:
The previous implementation performed three sequential database queries to compute the closure status variables: one for total followers, one for confirmed closures, and one for disputed closures. Combining the two confirmation type queries into one GROUP BY reduces database round-trips.

📊 Impact:
Reduces the number of database queries required to load the closure status from 3 to 2, mitigating potential N+1 or high latency issues on heavily-followed grievances and decreasing database load.

🔬 Measurement:
The performance improvement can be measured by tracing database calls during a GET /grievances/{id}/closure-status request; only 2 queries will be executed instead of 3.

---

PR created automatically by Jules for task 7200736870002847135 started by @RohanExploit

---

Summary by cubic

Consolidated closure status queries in get_closure_status to reduce database calls. Replaced two separate COUNT queries on ClosureConfirmation with a single GROUP BY on confirmation_type, bringing total queries from 3 to 2 and lowering latency for heavily followed grievances.

^{Written for commit 3102912. Summary will update on new commits.}

Summary by CodeRabbit

• Refactor
  • Optimized database query performance in the grievances module by consolidating multiple separate count operations into a single aggregated query, reducing the number of database calls required.

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[netlify]

👷 Deploy Preview for fixmybharat processing.

Name	Link
🔨 Latest commit	3102912
🔍 Latest deploy log	https://app.netlify.com/projects/fixmybharat/deploys/69b96482d1aadd0008788cee

[github-actions]

🙏 Thank you for your contribution, @RohanExploit!

PR Details:

• Title: ⚡ Bolt: [performance improvement] Consolidate closure status queries
• Number: ⚡ Bolt: [performance improvement] Consolidate closure status queries #556

Quality Checklist:
Please ensure your PR meets the following criteria:

• Code follows the project's style guidelines
• Self-review of code completed
• Code is commented where necessary
• Documentation updated (if applicable)
• No new warnings generated
• Tests added/updated (if applicable)
• All tests passing locally
• No breaking changes to existing functionality

Review Process:

1. Automated checks will run on your code
2. A maintainer will review your changes
3. Address any requested changes promptly
4. Once approved, your PR will be merged! 🎉

Note: The maintainers will monitor code quality and ensure the overall project flow isn't broken.

[coderabbitai]

📝 Walkthrough

Walkthrough

Consolidates two separate database count queries for ClosureConfirmation records into a single grouped aggregation query that returns counts per confirmation type. The endpoint then constructs confirmations_count and disputes_count from the aggregated results, reducing database round-trips while preserving existing functionality.

Changes

Cohort / File(s)	Summary
Database Query Consolidation backend/routers/grievances.py	Replaces two scalar count queries with a single grouped aggregation that counts ClosureConfirmation records by confirmation_type, then unpacks the results into separate count variables.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• ⚡ Bolt: [performance improvement] Optimize endpoint DB queries #549: Applies the same DB-query consolidation pattern (replacing multiple scalar aggregates with single grouped queries) across multiple router endpoints.
• ⚡ Bolt: optimize database queries and api response caching #480: Similar consolidation of multiple per-category count queries into a single GROUP BY aggregation in the same backend/routers/grievances.py file.
• feat: Add community confirmation before grievance closure (Issue #289) #328: Added the original closure confirmation counting logic that this PR optimizes by consolidating the multiple queries into one.

Suggested labels

size/s, medium

Poem

🐰 One query hops where two once stood,
Grouped and swift, efficient as it should,
Fewer round-trips through the warren deep,
More data gathered in a single leap!

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately reflects the main change: consolidating closure status queries for performance improvement, matching the PR's primary objective.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Description check	✅ Passed	The pull request description is comprehensive and well-structured, covering what was changed, why it was changed, and the measurable impact.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

• 📝 Generate docstrings (stacked PR)
• 📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch bolt-optimize-closure-status-queries-7200736870002847135

📝 Coding Plan

• Generate coding plan for human review comments

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Tip

You can customize the high-level summary generated by CodeRabbit.

Configure the reviews.high_level_summary_instructions setting to provide custom instructions for generating the high-level summary.

[cubic-dev-ai]

No issues found across 1 file

[Copilot]

Pull request overview

This PR improves the performance of the GET /grievances/{id}/closure-status endpoint by reducing database round-trips when computing closure confirmation counts, replacing multiple COUNT queries on closure_confirmations with a single GROUP BY aggregation.

Changes:

• Consolidated confirmed/disputed closure counts into one GROUP BY query.
• Converted grouped results into a dictionary to preserve the existing response fields (confirmations_count, disputes_count).

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.