Skip to content

⚡ Bolt: [performance improvement] Consolidate closure status queries #556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RohanExploit wants to merge 2 commits into
base: main
Choose a base branch
from
Open

⚡ Bolt: [performance improvement] Consolidate closure status queries #556

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
11c29b1
⚡ Bolt: [performance improvement] Consolidate closure status queries
RohanExploit Mar 17, 2026
3102912
⚡ Bolt: [performance improvement] Consolidate closure status queries
RohanExploit Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions backend/routers/grievances.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,15 +402,19 @@ def get_closure_status(
GrievanceFollower.grievance_id == grievance_id
).scalar()

confirmations_count = db.query(func.count(ClosureConfirmation.id)).filter(
ClosureConfirmation.grievance_id == grievance_id,
ClosureConfirmation.confirmation_type == "confirmed"
).scalar()
# Optimized: Single query with group_by replaces multiple count queries
closure_counts = db.query(
ClosureConfirmation.confirmation_type,
func.count(ClosureConfirmation.id)
).filter(
ClosureConfirmation.grievance_id == grievance_id
).group_by(
ClosureConfirmation.confirmation_type
).all()

disputes_count = db.query(func.count(ClosureConfirmation.id)).filter(
ClosureConfirmation.grievance_id == grievance_id,
ClosureConfirmation.confirmation_type == "disputed"
).scalar()
counts_dict = {ctype: count for ctype, count in closure_counts}
confirmations_count = counts_dict.get("confirmed", 0)
disputes_count = counts_dict.get("disputed", 0)

required_confirmations = max(1, int(total_followers * ClosureService.CONFIRMATION_THRESHOLD))

Expand Down
Loading