Swift Package Manager compatibility#37
Swift Package Manager compatibility#37ddorizy wants to merge 2 commits intoRxSwiftCommunity:masterfrom
Conversation
| .package(url: "https://github.com/ReactiveX/RxSwift", from: "4.5.0") | ||
| ], | ||
| targets: [ | ||
| .target(name: "RxWebKit", dependencies: ["RxSwift", "RxCocoa"], path: "RxWebKit") |
There was a problem hiding this comment.
RxWebKit has tests - the Package.swift file should have a test target as well
There was a problem hiding this comment.
I'm not sure I understand, tests targets should not be exposed in the SPM manifest file should they?
There was a problem hiding this comment.
AFAIK Package.swift targets are used for public targets but test targets are only for running “Swift test” etc.
Package.swift
Outdated
| .library(name: "RxWebKit", targets: ["RxWebKit"]) | ||
| ], | ||
| dependencies: [ | ||
| .package(url: "https://github.com/ReactiveX/RxSwift", from: "4.5.0") |
|
Just wanted to check the status on this Pull Requets. |
| .library(name: "RxWebKit", targets: ["RxWebKit"]) | ||
| ], | ||
| dependencies: [ | ||
| .package(url: "https://github.com/ReactiveX/RxSwift", from: "5.0.1") |
There was a problem hiding this comment.
| .package(url: "https://github.com/ReactiveX/RxSwift", from: "5.0.1") | |
| .package(url: "https://github.com/ReactiveX/RxSwift", from: "5.0.1"), | |
| .package(url: "https://github.com/Quick/Quick.git", from: "2.2.0"), | |
| .package(url: "https://github.com/Quick/Nimble.git", .branch("master")) | |
| ] |
There was a problem hiding this comment.
master for now: mattgallagher/CwlPreconditionTesting#16
| .package(url: "https://github.com/ReactiveX/RxSwift", from: "5.0.1") | ||
| ], | ||
| targets: [ | ||
| .target(name: "RxWebKit", dependencies: ["RxSwift", "RxCocoa"], path: "RxWebKit") |
There was a problem hiding this comment.
| .target(name: "RxWebKit", dependencies: ["RxSwift", "RxCocoa"], path: "RxWebKit") | |
| .target(name: "RxWebKit", dependencies: ["RxSwift", "RxCocoa"], path: "RxWebKit"), | |
| .testTarget(name: "RxWebKitTests", dependencies: ["RxWebKit", "RxSwift", "RxCocoa", "RxTest", "Quick", "Nimble"], path: "RxWebKitTests") |
| import PackageDescription | ||
|
|
||
| let package = Package( | ||
| name: "RxWebKit", |
There was a problem hiding this comment.
| name: "RxWebKit", | |
| name: "RxWebKit", | |
| platforms: [.iOS(.v8)], |
|
Is anyone interested in finishing the work on this? |
5 participants
Added Swift Package Manager manifest file for RxWebKit