Conversation
|
Hey, it's stuck here for a while. Any idea when this PR is going to be merged? |
|
I will have a look into this in the next couple of days |
Package.swift
Outdated
| let package = Package( | ||
| name: "RxWebKit", | ||
| platforms: [ | ||
| .iOS(.v8) |
There was a problem hiding this comment.
Unless there is a specific need (such as APIs used), it's best to leave this unspecified so that SwiftPM can set the minimum platform version to that which is supported by the toolchain.
This is especially important in the era of Xcode 12, as it drops support for iOS 8, making this package unusable with Xcode 12.
|
@mRs- Were you able to take a look at this? It's now October, and we're wanting to use this library with SwiftPM without forking (even though this library is extremely stable and doesn't see frequent changes) |
|
@mRs- pinging you again, can we get a review on this? |
|
Another ping. 2+ years needed in order to add a SPM support? |
7 participants
This PR take over #37.