Skip to content

Conversation

@thompson318
Copy link
Collaborator

A joint pull request addressing #1 and #5. Got slightly jumbled because jeremy/docker was branched off 1-csv-writer rather than dev but OK I think.

Creates a docker container for the waveform-controller and a volume to save the data (similar to the saving of raw hl7 this will result in waveform_data directory belonging to root) We can fix this I think by mounting with a difference username (similar to https://github.com/inform-us/INFORMus/issues/1507#issuecomment-2447767038).

Writes csv data to a new directory caller waveform_data. I file per day per source, currently it looks like about 64Mb per day. Maybe OK in the short term but will need addressing soon.

@thompson318 thompson318 mentioned this pull request Dec 2, 2025
1 task
@thompson318 thompson318 marked this pull request as ready for review December 2, 2025 12:21
@jeremyestein
Copy link
Collaborator

jeremyestein commented Dec 2, 2025

this will result in waveform_data directory belonging to root) We can fix this I think by mounting with a difference username (similar to inform-us/INFORMus#1507 (comment)).

The fix linked is to do with the build cache — I don't think this will affect what the container does at runtime. If you run it as the GID for "docker" on the GAE it should create files owned by root:docker, which should be readable as long as the root mount dir has been created outside of docker. Ideally we'd also not run as root, but I'm looking into getting a service account set up for that.

Anyway, this can be a separate issue. (opened #14)

Copy link
Collaborator

@jeremyestein jeremyestein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine, with a few suggestions. Don't mind if they're fixed here or in a separate PR. If we move to parquet, some are not relevant anyway.

@thompson318 thompson318 merged commit 7ccae8a into dev Dec 4, 2025
1 check passed
@thompson318 thompson318 deleted the jeremy/docker branch December 4, 2025 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants