Open
Conversation
yapf is a Python source code formatter, similar to clang-format. It has quite a lot of configuration options, which are stored in the file .style.yapf. I've adjusted the defaults from 79 to 80 columns line width, and some settins that handle line splitting of parenthesised, comma-separated content. These settings are my taste. The main reason is that overly long files are not easy to read and must be split at a certain length. This goes for comments as well. Also, git is a line-based tool, so having long lines also leads to more merge conflicts.
fbrausse
force-pushed
the
fb/format-yapf
branch
from
44e8c7f to
842f54c
Compare
fbrausse
force-pushed
the
fb/format-yapf
branch
2 times, most recently
from
c06dd7b to
0336b37
Compare
Collaborator
|
I think ruff is more standard, due to it being to a lot faster and more up to Ate. Maybe switching to that would be a bit easier? It also goes really well with pre-commits |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the config file
.style.yapffor automated source code formatting to the top-level directory and applies it to smlp_regr.py.yapf is a Python source code formatter, similar to clang-format. It has quite
a lot of configuration options, which are stored in the file .style.yapf.
I've adjusted the defaults from 79 to 80 columns line width, and some settings
that handle line splitting of parenthesised, comma-separated content. These
settings are my taste.
The main reason is that overly long files are not easy to read and must be
split at a certain length. This goes for comments as well. Also, git is a
line-based tool, so having long lines also leads to more merge conflicts.
If this PR is approved, I suggest to run yapf over all .py files in this repo. We can also do that within this PR.