-
Notifications
You must be signed in to change notification settings - Fork 2
Fix Standalone Timing Grep for LST #223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
649af55 to
4665f32
Compare
| grep -h "Time for map " timing_temp.txt | cut -d " " -f 6 | awk '{ SUM += $1} END { print "Average time for map loading =",SUM/5,"ms" }' # 5 is the number of stream values run | ||
| grep -h "Time for input " timing_temp.txt | cut -d " " -f 6 | awk '{ SUM += $1} END { print "Average time for input loading =",SUM/5,"ms" }' # 5 is the number of stream values run | ||
| grep -h "Time for event " timing_temp.txt | cut -d " " -f 6 | awk '{ SUM += $1} END { print "Average time for lst::Event creation =",SUM/21,"ms"}' # 5 is the number of total streams run (1+2+4+6+8) | ||
| grep -ah "Time for map " timing_temp.txt | cut -d " " -f 6 | awk '{ SUM += $1} END { print "Average time for map loading =",SUM/5,"ms" }' # 5 is the number of stream values run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did some special character creep in here now?
Where is it from, do you know?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's coming from the device printout in lst.cc, Running for Acc = AccGpuCudaRt<3,unsigned int�> at the end there is a null byte:
cmssw/RecoTracker/LSTCore/standalone/bin/lst.cc
Lines 313 to 316 in 5561045
| std::cout << "=========================================================" << std::endl; | |
| std::cout << " Running for Acc = " << alpaka::getAccName<ALPAKA_ACCELERATOR_NAMESPACE::Acc3D>() << std::endl; | |
| std::cout << " Setting of the analysis job based on provided arguments " << std::endl; | |
| std::cout << "---------------------------------------------------------" << std::endl; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's coming from the device printout in
lst.cc,Running for Acc = AccGpuCudaRt<3,unsigned int�>at the end there is a null byte:
ah, right, it's the same as the CI grep that was fixed a while back.
and the fix in alpaka available since 2.1.0 is only in the upstream from 16_1_0_pre1 counting the pre-releases
slava77
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes look fine to me. I wanted to propose to tack it on the #224.
At least in the past week our standalone-only PRs were not making good progress being merged upstream
Current timing script is broken for LST, summary printout is empty. This small PR fixes it. Also stops
--allobjfrom crashing on the standard samples by removing the jet branches from the option.