Skip to content

Conversation

@GNiendorf
Copy link
Member

@GNiendorf GNiendorf commented Jan 20, 2026

Current timing script is broken for LST, summary printout is empty. This small PR fixes it. Also stops --allobj from crashing on the standard samples by removing the jet branches from the option.

grep -h "Time for map " timing_temp.txt | cut -d " " -f 6 | awk '{ SUM += $1} END { print "Average time for map loading =",SUM/5,"ms" }' # 5 is the number of stream values run
grep -h "Time for input " timing_temp.txt | cut -d " " -f 6 | awk '{ SUM += $1} END { print "Average time for input loading =",SUM/5,"ms" }' # 5 is the number of stream values run
grep -h "Time for event " timing_temp.txt | cut -d " " -f 6 | awk '{ SUM += $1} END { print "Average time for lst::Event creation =",SUM/21,"ms"}' # 5 is the number of total streams run (1+2+4+6+8)
grep -ah "Time for map " timing_temp.txt | cut -d " " -f 6 | awk '{ SUM += $1} END { print "Average time for map loading =",SUM/5,"ms" }' # 5 is the number of stream values run
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did some special character creep in here now?
Where is it from, do you know?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's coming from the device printout in lst.cc, Running for Acc = AccGpuCudaRt<3,unsigned int�> at the end there is a null byte:

std::cout << "=========================================================" << std::endl;
std::cout << " Running for Acc = " << alpaka::getAccName<ALPAKA_ACCELERATOR_NAMESPACE::Acc3D>() << std::endl;
std::cout << " Setting of the analysis job based on provided arguments " << std::endl;
std::cout << "---------------------------------------------------------" << std::endl;

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's coming from the device printout in lst.cc, Running for Acc = AccGpuCudaRt<3,unsigned int�> at the end there is a null byte:

ah, right, it's the same as the CI grep that was fixed a while back.
and the fix in alpaka available since 2.1.0 is only in the upstream from 16_1_0_pre1 counting the pre-releases

Copy link

@slava77 slava77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look fine to me. I wanted to propose to tack it on the #224.
At least in the past week our standalone-only PRs were not making good progress being merged upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants