Skip to content

Fix Standalone Timing Grep for LST #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GNiendorf wants to merge 2 commits into
base: master
Choose a base branch
from
+8 −8
Open

Fix Standalone Timing Grep for LST #223

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
62fd8c8
fix standalone timing grep for LST
GNiendorf Jan 20, 2026
4665f32
don't trigger jet branches on allobj
GNiendorf Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions RecoTracker/LSTCore/standalone/bin/lst.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,14 +310,14 @@ int main(int argc, char **argv) {
// --t4dnn
ana.t4dnn_branches = result["t4dnn"].as<bool>() || result["allobj"].as<bool>();

//_______________________________________________________________________________
// --jet
ana.jet_branches = result["jet"].as<bool>() || result["allobj"].as<bool>();

//_______________________________________________________________________________
// --sim
ana.extra_sim_branches = result["sim"].as<bool>() || result["allobj"].as<bool>();

//_______________________________________________________________________________
// --jet (Not triggered by allobj since most files don't have jet info)
ana.jet_branches = result["jet"].as<bool>();

// Printing out the option settings overview
std::cout << "=========================================================" << std::endl;
std::cout << " Running for Acc = " << alpaka::getAccName<ALPAKA_ACCELERATOR_NAMESPACE::Acc3D>() << std::endl;
Expand Down
8 changes: 4 additions & 4 deletions RecoTracker/LSTCore/standalone/efficiency/bin/lst_timing
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,8 +146,8 @@ if [ -z "${SPECIFICGPUVERSION}" ] || [[ "${SPECIFICGPUVERSION}" == "explicit" ]]
fi

echo "Total Timing Summary"
grep -h "Time for map " timing_temp.txt | cut -d " " -f 6 | awk '{ SUM += $1} END { print "Average time for map loading =",SUM/5,"ms" }' # 5 is the number of stream values run
grep -h "Time for input " timing_temp.txt | cut -d " " -f 6 | awk '{ SUM += $1} END { print "Average time for input loading =",SUM/5,"ms" }' # 5 is the number of stream values run
grep -h "Time for event " timing_temp.txt | cut -d " " -f 6 | awk '{ SUM += $1} END { print "Average time for lst::Event creation =",SUM/21,"ms"}' # 5 is the number of total streams run (1+2+4+6+8)
grep -ah "Time for map " timing_temp.txt | cut -d " " -f 6 | awk '{ SUM += $1} END { print "Average time for map loading =",SUM/5,"ms" }' # 5 is the number of stream values run
Copy link

@slava77 slava77 Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did some special character creep in here now?
Where is it from, do you know?

Copy link
Member Author

@GNiendorf GNiendorf Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's coming from the device printout in lst.cc, Running for Acc = AccGpuCudaRt<3,unsigned int�> at the end there is a null byte:

cmssw/RecoTracker/LSTCore/standalone/bin/lst.cc

Lines 313 to 316 in 5561045

std::cout << "=========================================================" << std::endl;
std::cout << " Running for Acc = " << alpaka::getAccName<ALPAKA_ACCELERATOR_NAMESPACE::Acc3D>() << std::endl;
std::cout << " Setting of the analysis job based on provided arguments " << std::endl;
std::cout << "---------------------------------------------------------" << std::endl;

Copy link

@slava77 slava77 Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's coming from the device printout in lst.cc, Running for Acc = AccGpuCudaRt<3,unsigned int�> at the end there is a null byte:

ah, right, it's the same as the CI grep that was fixed a while back.
and the fix in alpaka available since 2.1.0 is only in the upstream from 16_1_0_pre1 counting the pre-releases

grep -ah "Time for input " timing_temp.txt | cut -d " " -f 6 | awk '{ SUM += $1} END { print "Average time for input loading =",SUM/5,"ms" }' # 5 is the number of stream values run
grep -ah "Time for event " timing_temp.txt | cut -d " " -f 6 | awk '{ SUM += $1} END { print "Average time for lst::Event creation =",SUM/21,"ms"}' # 5 is the number of total streams run (1+2+4+6+8)
echo " Evt Hits MD LS T3 T5 pLS T4 pT5 pT3 TC Reset Event Short Rate"
grep -hr "avg " timing_temp.txt # space is needed to not get certain bad lines
grep -ah "avg " timing_temp.txt